You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks @hugovk — fair point on the health score. I've reverted the ternaries and fixed the 3.10 timezone issue in the earlier push; this update adds a broader auto-fix pass (format/refactor/ruff aligned with your ruff config) plus a few targeted refactors: suffix lookup in `naturalsize`, `_today_for_value()` to dedupe the `naturalday`/`naturaldate` today logic, and the other safe changes listed in **Changes brought**.
1
+
Thanks @hugovk — fair point on the health score. I've reverted the ternaries and fixed
2
+
the 3.10 timezone issue in the earlier push; this update adds a broader auto-fix pass
3
+
(format/refactor/ruff aligned with your ruff config) plus a few targeted refactors:
4
+
suffix lookup in `naturalsize`, `_today_for_value()` to dedupe the
5
+
`naturalday`/`naturaldate` today logic, and the other safe changes listed in **Changes
6
+
brought**.
2
7
3
-
CI was green on my side after the revert push (`pre-commit.ci` + RTD). I can't add `changelog:*` labels from the fork — could you add one when you have a moment? Happy to adjust anything that's still not what you want.
8
+
CI was green on my side after the revert push (`pre-commit.ci` + RTD). I can't add
9
+
`changelog:*` labels from the fork — could you add one when you have a moment? Happy to
Copy file name to clipboardExpand all lines: pr-body.md
+38-21Lines changed: 38 additions & 21 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,14 @@
2
2
3
3
**Repo health:** 68/100
4
4
5
-
Our analysis found **90 format issues** and about **49 refactoring opportunities** across the reviewed scope. Security scans (gitleaks, bandit, semgrep) were clean; pip-audit reported no known vulnerabilities. Python code duplication is low (~0.7% in `.py` files). Radon maintainability ranks are mostly A-grade, but several functions exceed cyclomatic-complexity thresholds — notably `naturaldelta` and `precisedelta` in `time.py`. This pull request applies an **auto-fix pass** aligned with your project config — **5 files**, ~46 focused line changes — plus a few targeted refactors; it is not a complete cleanup of every finding.
5
+
Our analysis found **90 format issues** and about **49 refactoring opportunities**
6
+
across the reviewed scope. Security scans (gitleaks, bandit, semgrep) were clean;
7
+
pip-audit reported no known vulnerabilities. Python code duplication is low (~0.7% in
8
+
`.py` files). Radon maintainability ranks are mostly A-grade, but several functions
9
+
exceed cyclomatic-complexity thresholds — notably `naturaldelta` and `precisedelta` in
10
+
`time.py`. This pull request applies an **auto-fix pass** aligned with your project
11
+
config — **5 files**, ~46 focused line changes — plus a few targeted refactors; it is
12
+
not a complete cleanup of every finding.
6
13
7
14
## What you are doing right
8
15
@@ -22,37 +29,43 @@ Our analysis found **90 format issues** and about **49 refactoring opportunities
22
29
23
30
**Duplicate code (follow-up)**
24
31
25
-
-~0.7% duplication in Python — primary clone: `time.py` today-calculation for `naturalday` / `naturaldate` — **partially addressed** by extracting `_today_for_value`.
32
+
-~0.7% duplication in Python — primary clone: `time.py` today-calculation for
33
+
`naturalday` / `naturaldate` — **partially addressed** by extracting
34
+
`_today_for_value`.
26
35
27
36
**Refactoring (~49 opportunities; sample in this PR)**
28
37
29
38
- Collapse suffix selection in `naturalsize` (`filesize.py`) — **included in this PR**.
30
39
- Flatten `natural_list` branching (`lists.py`) — **included in this PR**.
31
40
- Remove redundant `int()` cast in `metric` (`number.py`) — **included in this PR**.
32
-
- Yoda comparison fix and `zip(..., strict=True)` in `time.py` — **included in this PR**.
41
+
- Yoda comparison fix and `zip(..., strict=True)` in `time.py` — **included in this
| Lint |`format` parameter name (A002) | Stable API surface|
75
88
76
89
</details>
77
90
78
91
---
79
-
*We're testing [ShipGate](https://github.com/inquilabee/shipgate) on real-world projects to learn whether it works well in practice. This review summary was generated from ShipGate check output and AI-assisted analysis. Feedback on the findings or approach is welcome and appreciated — [docs](https://inquilabee.github.io/shipgate/).*
92
+
93
+
_We're testing [ShipGate](https://github.com/inquilabee/shipgate) on real-world projects
94
+
to learn whether it works well in practice. This review summary was generated from
95
+
ShipGate check output and AI-assisted analysis. Feedback on the findings or approach is
96
+
welcome and appreciated — [docs](https://inquilabee.github.io/shipgate/)._
Copy file name to clipboardExpand all lines: shipgate-review/SUMMARY.md
+38-21Lines changed: 38 additions & 21 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -2,7 +2,14 @@
2
2
3
3
**Repo health:** 68/100
4
4
5
-
Our analysis found **90 format issues** and about **49 refactoring opportunities** across the reviewed scope. Security scans (gitleaks, bandit, semgrep) were clean; pip-audit reported no known vulnerabilities. Python code duplication is low (~0.7% in `.py` files). Radon maintainability ranks are mostly A-grade, but several functions exceed cyclomatic-complexity thresholds — notably `naturaldelta` and `precisedelta` in `time.py`. This pull request applies an **auto-fix pass** aligned with your project config — **5 files**, ~46 focused line changes — plus a few targeted refactors; it is not a complete cleanup of every finding.
5
+
Our analysis found **90 format issues** and about **49 refactoring opportunities**
6
+
across the reviewed scope. Security scans (gitleaks, bandit, semgrep) were clean;
7
+
pip-audit reported no known vulnerabilities. Python code duplication is low (~0.7% in
8
+
`.py` files). Radon maintainability ranks are mostly A-grade, but several functions
9
+
exceed cyclomatic-complexity thresholds — notably `naturaldelta` and `precisedelta` in
10
+
`time.py`. This pull request applies an **auto-fix pass** aligned with your project
11
+
config — **5 files**, ~46 focused line changes — plus a few targeted refactors; it is
12
+
not a complete cleanup of every finding.
6
13
7
14
## What you are doing right
8
15
@@ -22,37 +29,43 @@ Our analysis found **90 format issues** and about **49 refactoring opportunities
22
29
23
30
**Duplicate code (follow-up)**
24
31
25
-
-~0.7% duplication in Python — primary clone: `time.py` today-calculation for `naturalday` / `naturaldate` — **partially addressed** by extracting `_today_for_value`.
32
+
-~0.7% duplication in Python — primary clone: `time.py` today-calculation for
33
+
`naturalday` / `naturaldate` — **partially addressed** by extracting
34
+
`_today_for_value`.
26
35
27
36
**Refactoring (~49 opportunities; sample in this PR)**
28
37
29
38
- Collapse suffix selection in `naturalsize` (`filesize.py`) — **included in this PR**.
30
39
- Flatten `natural_list` branching (`lists.py`) — **included in this PR**.
31
40
- Remove redundant `int()` cast in `metric` (`number.py`) — **included in this PR**.
32
-
- Yoda comparison fix and `zip(..., strict=True)` in `time.py` — **included in this PR**.
41
+
- Yoda comparison fix and `zip(..., strict=True)` in `time.py` — **included in this
| Lint |`format` parameter name (A002) | Stable API surface|
75
88
76
89
</details>
77
90
78
91
---
79
-
*We're testing [ShipGate](https://github.com/inquilabee/shipgate) on real-world projects to learn whether it works well in practice. This review summary was generated from ShipGate check output and AI-assisted analysis. Feedback on the findings or approach is welcome and appreciated — [docs](https://inquilabee.github.io/shipgate/).*
92
+
93
+
_We're testing [ShipGate](https://github.com/inquilabee/shipgate) on real-world projects
94
+
to learn whether it works well in practice. This review summary was generated from
95
+
ShipGate check output and AI-assisted analysis. Feedback on the findings or approach is
96
+
welcome and appreciated — [docs](https://inquilabee.github.io/shipgate/)._
0 commit comments