From dbe401a1a360a24d4e480f5aef589f0967efec0e Mon Sep 17 00:00:00 2001 From: Rom1-B <8530352+Rom1-B@users.noreply.github.com> Date: Tue, 6 Oct 2026 16:27:55 +0200 Subject: [PATCH 1/2] 1.3.1 --- CHANGELOG.md | 2 +- advancedforms.xml | 5 +++++ setup.php | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a39684d..c0dd931 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). -## [Unreleased] +## [1.3.1] - 2026-10-06 ### Added diff --git a/advancedforms.xml b/advancedforms.xml index 2a8094f..dbfc4df 100644 --- a/advancedforms.xml +++ b/advancedforms.xml @@ -25,6 +25,11 @@ Teclib' + + 1.3.1 + ~11.0.7 + https://github.com/pluginsGLPI/advancedforms/releases/download/1.3.1/glpi-advancedforms-1.3.1.tar.bz2 + 1.3.0 ~11.0.7 diff --git a/setup.php b/setup.php index 8e4bb84..ba4f51f 100644 --- a/setup.php +++ b/setup.php @@ -36,7 +36,7 @@ use GlpiPlugin\Advancedforms\Service\InitManager; /** @phpstan-ignore theCodingMachineSafe.function (safe to assume this isn't already defined) */ -define('PLUGIN_ADVANCEDFORMS_VERSION', '1.3.0'); +define('PLUGIN_ADVANCEDFORMS_VERSION', '1.3.1'); // Minimal GLPI version, inclusive /** @phpstan-ignore theCodingMachineSafe.function (safe to assume this isn't already defined) */ From 12fd00b89121ee8ad9556c378d4e49a512b3dae4 Mon Sep 17 00:00:00 2001 From: Rom1-B <8530352+Rom1-B@users.noreply.github.com> Date: Wed, 7 Oct 2026 08:08:07 +0200 Subject: [PATCH 2/2] fix playwright --- tests/e2e/specs/reservation_question.spec.ts | 4 +++- tests/e2e/specs/table_question.spec.ts | 12 +++++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/tests/e2e/specs/reservation_question.spec.ts b/tests/e2e/specs/reservation_question.spec.ts index bb97d23..945e935 100644 --- a/tests/e2e/specs/reservation_question.spec.ts +++ b/tests/e2e/specs/reservation_question.spec.ts @@ -106,7 +106,9 @@ test.describe('Advanced forms - Material reservation question', () => { await expect(reservation.getAvailabilityMessage(widget)).toHaveText('This slot is available'); await page.getByRole('button', { name: 'Submit' }).click(); - await expect(page.getByRole('link', { name: form_name })).toBeVisible(); + // Scoped to the success alert, since the same link also appears + // permanently in the ticket's "Items" tab. + await expect(form.getAlert(form_name).getByRole('link', { name: form_name })).toBeVisible(); }); }); diff --git a/tests/e2e/specs/table_question.spec.ts b/tests/e2e/specs/table_question.spec.ts index cc87ff9..f2cc764 100644 --- a/tests/e2e/specs/table_question.spec.ts +++ b/tests/e2e/specs/table_question.spec.ts @@ -107,7 +107,9 @@ test.describe('Advanced forms - Table question', () => { await page.getByRole('button', { name: 'Submit' }).click(); // A link to the created answer/item confirms the submission succeeded. - await expect(page.getByRole('link', { name: form_name })).toBeVisible(); + // Scoped to the success alert, since the same link also appears + // permanently in the ticket's "Items" tab. + await expect(form.getAlert(form_name).getByRole('link', { name: form_name })).toBeVisible(); }); }); @@ -178,7 +180,9 @@ test.describe('Advanced forms - Table question', () => { await expect(table.getEndUserCell(eu_table, 0, 0)).not.toHaveClass(/is-invalid/); await page.getByRole('button', { name: 'Submit' }).click(); - await expect(page.getByRole('link', { name: form_name })).toBeVisible(); + // Scoped to the success alert, since the same link also appears + // permanently in the ticket's "Items" tab. + await expect(form.getAlert(form_name).getByRole('link', { name: form_name })).toBeVisible(); }); }); @@ -222,7 +226,9 @@ test.describe('Advanced forms - Table question', () => { await page.getByRole('button', { name: 'Submit' }).click(); - await expect(page.getByRole('link', { name: form_name })).toBeVisible(); + // Scoped to the success alert, since the same link also appears + // permanently in the ticket's "Items" tab. + await expect(form.getAlert(form_name).getByRole('link', { name: form_name })).toBeVisible(); }); });