Fix validate_colors_dict, convert_dict_colors_to_same_type and convert_colorscale_to_rgb modifying their input

Author: Enesuygurs

CHANGELOG.md

@@ -21,7 +21,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - Fix `convert_dash` mapping dotted lines (`linestyle=':'`) to invalid `'circle'` in Plotly, correctly converting them to `'dot'` and preserving custom dash patterns as pixel lists, [[#5719](https://github.com/plotly/plotly.py/pull/5719)] with thanks to @robertoffmoura for the contribution!
 - Fix `px.sunburst`, `px.treemap` and `px.icicle` listing sectors in a different order on every run when `path` is used with a Polars DataFrame; sectors now follow their order of first appearance for all dataframe backends [[#5766](https://github.com/plotly/plotly.py/pull/5766)], with thanks to @Irahan2 for the contribution!
 - Fix `mpl_to_plotly` conversion of matplotlib contour lines and line collections: close contour rings ending with `Z` codes, support dash styles, convert date x-axes, separate disjoint subpaths with `None` separators, hide line collection traces from the legend by default, and group consecutive same-style lines into single traces [[#5770](https://github.com/plotly/plotly.py/pull/5770)], with thanks to @robertoffmoura for the contribution!
-- Fix `plotly.colors.validate_colors` and `plotly.colors.convert_colors_to_same_type` modifying the list of colors passed to them in place, which also changed `plotly.colors.DEFAULT_PLOTLY_COLORS` (for example after calling `create_trisurf` without a `colormap`) and built-in color sequences such as `plotly.colors.sequential.Inferno` [[#5836](https://github.com/plotly/plotly.py/pull/5836)], with thanks to @Enesuygurs for the contribution!
+- Fix `plotly.colors.validate_colors`, `plotly.colors.convert_colors_to_same_type`, `plotly.colors.validate_colors_dict`, `plotly.colors.convert_dict_colors_to_same_type` and `plotly.colors.convert_colorscale_to_rgb` modifying the colors or colorscale passed to them in place, which also changed `plotly.colors.DEFAULT_PLOTLY_COLORS` (for example after calling `create_trisurf` without a `colormap`) and built-in color sequences such as `plotly.colors.sequential.Inferno` [[#5836](https://github.com/plotly/plotly.py/pull/5836)], with thanks to @Enesuygurs for the contribution!
 
 ## [7.1.0] - 2026-09-15
 

_plotly_utils/colors/__init__.py

@@ -382,6 +382,9 @@ def validate_colors_dict(colors, colortype="tuple"):
     """
     Validates dictionary of color(s)
     """
+    # copy the dict so that the caller's dict is not modified in place below
+    colors = dict(colors)
+
     # validate each color element in the dictionary
     for key in colors:
         if "rgb" in colors[key]:
@@ -503,6 +506,9 @@ def convert_dict_colors_to_same_type(colors_dict, colortype="rgb"):
 
     :param (dict) colors_dict: a dictionary whose values are single colors
     """
+    # copy the dict so that the caller's dict is not modified in place below
+    colors_dict = dict(colors_dict)
+
     for key in colors_dict:
         if "#" in colors_dict[key]:
             colors_dict[key] = color_parser(colors_dict[key], hex_to_rgb)
@@ -823,6 +829,10 @@ def convert_colorscale_to_rgb(colorscale):
     converting a colorscale with tuple colors (each coordinate between 0
     and 1) into a colorscale with the colors transformed into rgb colors
     """
+    # copy the colorscale and its [scale, color] pairs so that the caller's
+    # colorscale is not modified in place below
+    colorscale = [list(color) for color in colorscale]
+
     for color in colorscale:
         color[1] = convert_to_RGB_255(color[1])
 

tests/test_core/test_colors/test_colors.py

@@ -72,6 +72,19 @@ def test_color_conversions_do_not_modify_input(self):
         colors.convert_colors_to_same_type(color_list, colortype="tuple")
         self.assertEqual(color_list, ["rgb(255, 0, 0)", "#0000ff"])
 
+        color_dict = {"a": "rgb(255, 0, 0)", "b": "#0000ff", "c": (0.5, 0.5, 0.5)}
+        expected_dict = dict(color_dict)
+
+        colors.validate_colors_dict(color_dict, colortype="rgb")
+        self.assertEqual(color_dict, expected_dict)
+
+        colors.convert_dict_colors_to_same_type(color_dict, colortype="tuple")
+        self.assertEqual(color_dict, expected_dict)
+
+        colorscale = [[0, (0.0, 0.0, 0.0)], [1, (1.0, 1.0, 1.0)]]
+        colors.convert_colorscale_to_rgb(colorscale)
+        self.assertEqual(colorscale, [[0, (0.0, 0.0, 0.0)], [1, (1.0, 1.0, 1.0)]])
+
     def test_convert_dict_colors_to_same_type(self):
         # test colortype
         color_dict = dict(apple="rgb(1, 1, 1)")