From 3cd932fe5b36c733b0c7bb096d7ae6f6ccdb6959 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Fri, 4 Sep 2026 23:20:23 +0200 Subject: [PATCH 1/6] Fix PHP7.4 build --- composer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 53028f0b..fb74656d 100644 --- a/composer.json +++ b/composer.json @@ -9,7 +9,8 @@ "require": { "php": "^7.4 || ^8.0", "phar-io/version": "^3.2", - "phpstan/phpstan": "^2.2.6" + "phpstan/phpstan": "^2.2.6", + "symfony/polyfill-php80": "^1.37" }, "conflict": { "phpunit/phpunit": "<7.0" From 08705fa6b81972b76687604b6d504afd015831da Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Fri, 4 Sep 2026 23:21:28 +0200 Subject: [PATCH 2/6] Update composer.json --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index fb74656d..9416419b 100644 --- a/composer.json +++ b/composer.json @@ -10,7 +10,7 @@ "php": "^7.4 || ^8.0", "phar-io/version": "^3.2", "phpstan/phpstan": "^2.2.6", - "symfony/polyfill-php80": "^1.37" + "symfony/polyfill-php80": "^1" }, "conflict": { "phpunit/phpunit": "<7.0" From 7057ad9832fedc14ae8da1143b81d303dde23738 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Fri, 4 Sep 2026 23:46:54 +0200 Subject: [PATCH 3/6] fix --- src/Rules/PHPUnit/TestMethodsHelper.php | 3 +-- src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/Rules/PHPUnit/TestMethodsHelper.php b/src/Rules/PHPUnit/TestMethodsHelper.php index f1efc97f..be871cac 100644 --- a/src/Rules/PHPUnit/TestMethodsHelper.php +++ b/src/Rules/PHPUnit/TestMethodsHelper.php @@ -10,7 +10,6 @@ use PHPStan\Type\FileTypeMapper; use PHPUnit\Framework\TestCase; use function array_key_exists; -use function str_starts_with; use function strtolower; final class TestMethodsHelper @@ -62,7 +61,7 @@ public function getTestMethods(ClassReflection $classReflection, Scope $scope): continue; } - if (str_starts_with(strtolower($reflectionMethod->getName()), 'test')) { + if (strpos(strtolower($reflectionMethod->getName()), 'test') === 0) { $testMethods[] = $reflectionMethod; continue; } diff --git a/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php b/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php index ccf5b0f4..70055ce9 100644 --- a/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php +++ b/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php @@ -8,7 +8,6 @@ use PHPStan\Analyser\Scope; use PHPUnit\Framework\TestCase; use function is_string; -use function str_starts_with; final class DynamicCallToAssertionIgnoreExtension implements IgnoreErrorExtension { @@ -33,7 +32,7 @@ public function shouldIgnore(Error $error, Node $node, Scope $scope): bool if ( !$node->name instanceof Node\Identifier - || !str_starts_with($node->name->name, 'assert') + || strpos($node->name->name, 'assert') !== 0 ) { return false; } From 1df960b5aedc468e89626a583b635a86bc3841e6 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Fri, 4 Sep 2026 23:46:59 +0200 Subject: [PATCH 4/6] Revert "Update composer.json" This reverts commit 08705fa6b81972b76687604b6d504afd015831da. --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 9416419b..fb74656d 100644 --- a/composer.json +++ b/composer.json @@ -10,7 +10,7 @@ "php": "^7.4 || ^8.0", "phar-io/version": "^3.2", "phpstan/phpstan": "^2.2.6", - "symfony/polyfill-php80": "^1" + "symfony/polyfill-php80": "^1.37" }, "conflict": { "phpunit/phpunit": "<7.0" From 4e3672e723a11fac65a11322ba803c0dcd67b33b Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Fri, 4 Sep 2026 23:47:26 +0200 Subject: [PATCH 5/6] Update composer.json --- composer.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/composer.json b/composer.json index fb74656d..53028f0b 100644 --- a/composer.json +++ b/composer.json @@ -9,8 +9,7 @@ "require": { "php": "^7.4 || ^8.0", "phar-io/version": "^3.2", - "phpstan/phpstan": "^2.2.6", - "symfony/polyfill-php80": "^1.37" + "phpstan/phpstan": "^2.2.6" }, "conflict": { "phpunit/phpunit": "<7.0" From a327d12d612a8c1637b46562b9ec9eb1b9ec17e3 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Fri, 4 Sep 2026 23:50:09 +0200 Subject: [PATCH 6/6] cs --- src/Rules/PHPUnit/TestMethodsHelper.php | 1 + src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php | 1 + 2 files changed, 2 insertions(+) diff --git a/src/Rules/PHPUnit/TestMethodsHelper.php b/src/Rules/PHPUnit/TestMethodsHelper.php index be871cac..e07abb5d 100644 --- a/src/Rules/PHPUnit/TestMethodsHelper.php +++ b/src/Rules/PHPUnit/TestMethodsHelper.php @@ -10,6 +10,7 @@ use PHPStan\Type\FileTypeMapper; use PHPUnit\Framework\TestCase; use function array_key_exists; +use function strpos; use function strtolower; final class TestMethodsHelper diff --git a/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php b/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php index 70055ce9..35a0e983 100644 --- a/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php +++ b/src/Type/PHPUnit/DynamicCallToAssertionIgnoreExtension.php @@ -8,6 +8,7 @@ use PHPStan\Analyser\Scope; use PHPUnit\Framework\TestCase; use function is_string; +use function strpos; final class DynamicCallToAssertionIgnoreExtension implements IgnoreErrorExtension {