feedback

Author: LamentXU123

Zend/zend_operators.c

@@ -1097,7 +1097,13 @@ ZEND_API double ZEND_FASTCALL zval_try_get_double_func(const zval *op, bool *fai
 						return 0.0;
 					}
 				}
-				return type == IS_LONG ? (double) lval : dval;
+				if (type == IS_DOUBLE) {
+					return dval;
+				}
+				if (UNEXPECTED(lval == 0)) {
+					return zend_strtod(Z_STRVAL_P(op), NULL);
+				}
+				return (double) lval;
 			}
 		case IS_OBJECT:
 			{

ext/standard/tests/strings/pack_float_conversion.phpt

@@ -43,6 +43,13 @@ foreach ($formats as $format) {
     var_dump($infinity === INF && is_nan($nan));
 }
 
+echo "signed zero integer strings:\n";
+foreach ($formats as $format) {
+    $actual = unpack($format, pack($format, '-0'))[1];
+    echo "$format: ";
+    var_dump($actual === 0.0 && fdiv(1.0, $actual) === -INF);
+}
+
 echo "leading-numeric strings:\n";
 foreach ($formats as $format) {
     $diagnostic = null;
@@ -139,6 +146,13 @@ G: bool(true)
 d: bool(true)
 e: bool(true)
 E: bool(true)
+signed zero integer strings:
+f: bool(true)
+g: bool(true)
+G: bool(true)
+d: bool(true)
+e: bool(true)
+E: bool(true)
 leading-numeric strings:
 f: bool(true)
 g: bool(true)