From 733580b84d61456e7054408f39b8fdad5bd13882 Mon Sep 17 00:00:00 2001 From: Mgldvd <2009698+Mgldvd@users.noreply.github.com> Date: Mon, 26 Oct 2026 14:56:49 -0500 Subject: [PATCH 1/2] fix: run Codex review batches outside Git repositories --- desloppify/app/commands/runner/codex_batch.py | 2 ++ desloppify/tests/commands/test_runner_modules_direct.py | 1 + 2 files changed, 3 insertions(+) diff --git a/desloppify/app/commands/runner/codex_batch.py b/desloppify/app/commands/runner/codex_batch.py index 6fb754ab2..db70fd031 100644 --- a/desloppify/app/commands/runner/codex_batch.py +++ b/desloppify/app/commands/runner/codex_batch.py @@ -95,6 +95,8 @@ def codex_batch_command(*, prompt: str, repo_root: Path, output_file: Path) -> l *prefix, "exec", "--ephemeral", + # Scans also support source archives and directories without Git metadata. + "--skip-git-repo-check", "-C", str(repo_root), "-s", diff --git a/desloppify/tests/commands/test_runner_modules_direct.py b/desloppify/tests/commands/test_runner_modules_direct.py index 083885ca8..7ab57f7c6 100644 --- a/desloppify/tests/commands/test_runner_modules_direct.py +++ b/desloppify/tests/commands/test_runner_modules_direct.py @@ -174,6 +174,7 @@ def test_codex_batch_command_uses_sanitized_reasoning_effort(monkeypatch, tmp_pa assert any(c.endswith("codex") or "codex" in c for c in command[:3]) assert "exec" in command assert "--ephemeral" in command + assert "--skip-git-repo-check" in command assert f'model_reasoning_effort="high"' in command assert str(tmp_path) in command From 982b341608fcc99466e08ef190b72c531a594546 Mon Sep 17 00:00:00 2001 From: Mgldvd <2009698+Mgldvd@users.noreply.github.com> Date: Mon, 26 Oct 2026 14:56:59 -0500 Subject: [PATCH 2/2] style: format touched runner imports and assertions --- desloppify/app/commands/runner/codex_batch.py | 4 +++- desloppify/tests/commands/test_runner_modules_direct.py | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/desloppify/app/commands/runner/codex_batch.py b/desloppify/app/commands/runner/codex_batch.py index db70fd031..14c389ad3 100644 --- a/desloppify/app/commands/runner/codex_batch.py +++ b/desloppify/app/commands/runner/codex_batch.py @@ -16,7 +16,9 @@ resolve_retry_config, run_batch_attempt, ) -from desloppify.app.commands.review.runner_process_impl.io import extract_payload_from_log +from desloppify.app.commands.review.runner_process_impl.io import ( + extract_payload_from_log, +) from desloppify.app.commands.review.runner_process_impl.types import ( CodexBatchRunnerDeps, FollowupScanDeps, diff --git a/desloppify/tests/commands/test_runner_modules_direct.py b/desloppify/tests/commands/test_runner_modules_direct.py index 7ab57f7c6..c6452d0cb 100644 --- a/desloppify/tests/commands/test_runner_modules_direct.py +++ b/desloppify/tests/commands/test_runner_modules_direct.py @@ -175,7 +175,7 @@ def test_codex_batch_command_uses_sanitized_reasoning_effort(monkeypatch, tmp_pa assert "exec" in command assert "--ephemeral" in command assert "--skip-git-repo-check" in command - assert f'model_reasoning_effort="high"' in command + assert 'model_reasoning_effort="high"' in command assert str(tmp_path) in command monkeypatch.setenv("DESLOPPIFY_CODEX_REASONING_EFFORT", "invalid") @@ -184,7 +184,7 @@ def test_codex_batch_command_uses_sanitized_reasoning_effort(monkeypatch, tmp_pa repo_root=tmp_path, output_file=tmp_path / "out.json", ) - assert f'model_reasoning_effort="low"' in command + assert 'model_reasoning_effort="low"' in command def test_codex_batch_command_uses_sandbox_env_override(monkeypatch, tmp_path: Path) -> None: