Skip to content

Commit 32ef8cc

Browse files
authored
fix(docked nav): persistent inline nav (#12653)
* fix(docked nav): persist inline nav * fix(docked nav): remove isDockExpanded * fix(compass): add logic for persistent nav in compass demo * fix(docked nav): update logic from coderabbit * fix(docked nav): update logic from coderabbit
1 parent 5a3c923 commit 32ef8cc

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

‎packages/react-core/src/demos/Compass/examples/CompassDockDemo.tsx‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,10 @@ export const CompassDockDemo: React.FunctionComponent = () => {
111111
const onNavSelect = (_event: React.FormEvent<HTMLInputElement>, selectedItem: NavOnSelectProps) => {
112112
typeof selectedItem.itemId === 'number' && setActiveItem(selectedItem.itemId);
113113

114+
if (!isMobile && isDockTextExpanded) {
115+
return;
116+
}
117+
114118
setIsDockExpandableExpanded(false);
115119
setIsDockTextExpanded(false);
116120
setIsDockExpanded(false);

‎packages/react-core/src/demos/examples/Nav/NavDockedNav.tsx‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ export const NavDockedNav: React.FunctionComponent = () => {
114114
const onNavSelect = (_event: React.FormEvent<HTMLInputElement>, selectedItem: NavOnSelectProps) => {
115115
typeof selectedItem.itemId === 'number' && setActiveItem(selectedItem.itemId);
116116

117+
if (!isMobile && isDockTextExpanded) {
118+
return;
119+
}
120+
117121
setIsDockExpandableExpanded(false);
118122
setIsDockTextExpanded(false);
119123
setIsDockExpanded(false);

0 commit comments

Comments
 (0)