With the new implementation for OCIS shares listing (#4876), it's necessary to refactor all classes and methods related to the legacy sharing implementation to keep the codebase consistent.
OCS implementation → Use the Ocs prefix.
Graph API implementation → Use the Graph prefix (already done) ✅
Moreover, an additional check is needed in the XML files used for space members and shares to ensure that the ids are generic and consistent.
TODOs
- Refactor OCS classes adding the
Ocs prefix
- Refactor XML files used for space members and shares
- Move the adapter and the recycler view setup for roles in
AddMemberFragment to onViewCreated method
- Add a
delay to the members search to avoid repetitive requests when user types quickly
- Use extension functions to bind roles, date picker and other UI elements
- Refactor the members filter to match the implementation in
AddGraphShareFragment
TASKS
With the new implementation for OCIS shares listing (#4876), it's necessary to refactor all classes and methods related to the legacy sharing implementation to keep the codebase consistent.
OCS implementation → Use the
Ocsprefix.Graph API implementation → Use the
Graphprefix (already done) ✅Moreover, an additional check is needed in the XML files used for space members and shares to ensure that the ids are generic and consistent.
TODOs
OcsprefixAddMemberFragmenttoonViewCreatedmethoddelayto the members search to avoid repetitive requests when user types quicklyAddGraphShareFragmentTASKS