From 3e66967e8a2d69710b9dda94bd34da8dfb864d7f Mon Sep 17 00:00:00 2001 From: Mark Harris Date: Wed, 1 Jul 2026 02:29:26 +0000 Subject: [PATCH 1/3] Add CODEOWNERS requiring NVIDIA review for governance/CI files Introduce a CODEOWNERS file (kept identical across the fvdb repos) so that any maintainer (fvdb-dev) reviews code by default, while governance, legal, and CI/CD infrastructure require an NVIDIA maintainer (fvdb-dev-nvidia). The patterns match files even before they exist, preventing a non-NVIDIA contributor from introducing them without NVIDIA approval. Co-Authored-By: Claude Opus 4.8 Signed-off-by: Mark Harris --- CODEOWNERS | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 CODEOWNERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 0000000..0d9f9d4 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,23 @@ +# fVDB CODEOWNERS +# See https://help.github.com/articles/about-codeowners/ +# for more info about CODEOWNERS file +# +# This file is kept identical across the fvdb-core, fvdb-reality-capture, +# and fvdb-examples repositories. Later matches take precedence over +# earlier ones. + +# Default owner for all files: any fVDB maintainer may review. +* @openvdb/fvdb-dev + +# Governance, legal, and CI/CD infrastructure require review from an +# NVIDIA maintainer (fvdb-dev-nvidia, a child team of fvdb-dev). These +# patterns match even when the file does not yet exist, so a non-NVIDIA +# contributor cannot add one without an NVIDIA maintainer's approval. +/.github/ @openvdb/fvdb-dev-nvidia +/CODEOWNERS @openvdb/fvdb-dev-nvidia +/LICENSE @openvdb/fvdb-dev-nvidia +/MAINTAINERS.md @openvdb/fvdb-dev-nvidia +/CODE_OF_CONDUCT.md @openvdb/fvdb-dev-nvidia +/CONTRIBUTING.md @openvdb/fvdb-dev-nvidia +/SECURITY.md @openvdb/fvdb-dev-nvidia +/.gitmodules @openvdb/fvdb-dev-nvidia From 2a9bcc4b43e6ba4534ed3d325a3d760876c70a2f Mon Sep 17 00:00:00 2001 From: Mark Harris Date: Wed, 1 Jul 2026 03:12:34 +0000 Subject: [PATCH 2/3] Fix governance doc links, heading, and grammar (Copilot review) Address review feedback on the governance docs: - MAINTAINERS.md: heading "Committers" -> "Maintainers" for consistency with the body. - CONTRIBUTING.md: fix broken in-page link (#committer -> #maintainer); point the broken local tsc/ CLA link to the canonical AcademySoftwareFoundation/openvdb TSC directory; "name and email is added" -> "are added". - CODE_OF_CONDUCT.md: point the broken local tsc/charter.md link to the canonical openvdb charter. - CONTRIBUTING.md: broken LICENSE.md link -> LICENSE. Co-Authored-By: Claude Opus 4.8 Signed-off-by: Mark Harris --- CODE_OF_CONDUCT.md | 2 +- CONTRIBUTING.md | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index ac9fbd2..5fa1cd3 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -1 +1 @@ -All participants agree to abide by LF Projects Code of Conduct (as defined in the [charter](tsc/charter.md)) available at https://lfprojects.org/policies/code-of-conduct/ +All participants agree to abide by LF Projects Code of Conduct (as defined in the [charter](https://github.com/AcademySoftwareFoundation/openvdb/blob/master/tsc/charter.md)) available at https://lfprojects.org/policies/code-of-conduct/ diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e40d829..0f63bcd 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,7 +13,7 @@ The contributor role is the starting role for anyone participating in the projec * Review the [coding standards](https://www.openvdb.org/documentation/doxygen/codingStyle.html) to ensure your contribution is in line with the project's coding and styling guidelines. * Have a signed CLA on file ( see [below](#contributor-license-agreements) ) * Submit your code as a PR with the appropriate [DCO sign-off](#commit-sign-off). -* Have your submission approved by the [committer(s)](#committer) and merged into the codebase. +* Have your submission approved by the [maintainer(s)](#maintainer) and merged into the codebase. ### Legal Requirements @@ -22,7 +22,7 @@ open source software best practice policies of the Linux Foundation. #### License -ƒVDB is licensed under the [Apache License, version 2.0](LICENSE.md) +ƒVDB is licensed under the [Apache License, version 2.0](LICENSE) license. Contributions to ƒVDB should abide by that standard license. @@ -46,7 +46,7 @@ can be merged. Agreement](https://docs.linuxfoundation.org/lfx/easycla/contributors/corporate-contributor). The ƒVDB CLAs are the standard forms used by Linux Foundation -projects and [recommended by the ASWF TAC](https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#contributor-license-agreement-cla). You can review the text of the CLAs in the [TSC directory](tsc/). +projects and [recommended by the ASWF TAC](https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#contributor-license-agreement-cla). You can review the text of the CLAs in the [TSC directory](https://github.com/AcademySoftwareFoundation/openvdb/tree/master/tsc). #### Commit Sign-Off @@ -54,7 +54,7 @@ Every commit must be signed off. That is, every commit log message must include a “`Signed-off-by`” line (generated, for example, with “`git commit --signoff`”), indicating that the committer wrote the code and has the right to release it under the -[Apache License, version 2.0](LICENSE.md) +[Apache License, version 2.0](LICENSE) license. See the [TAC documentation on contribution sign off](https://github.com/AcademySoftwareFoundation/tac/blob/master/process/contributing.md#contribution-sign-off) for more information on this requirement. ## Maintainer @@ -68,7 +68,7 @@ This role enables the participant to commit code directly to the repository, but * Show your experience with the codebase through contributions and engagement on the community channels. * Request to become a maintainer. * Have the majority of maintainers approve you becoming a maintainer. -* Your name and email is added to the MAINTAINERS.md file for the project. +* Your name and email are added to the MAINTAINERS.md file for the project. ### Maintainer responsibilities From d0ace1b5895dcbdd3cfae9650b5545d44a8cb521 Mon Sep 17 00:00:00 2001 From: Mark Harris Date: Wed, 1 Jul 2026 04:03:14 +0000 Subject: [PATCH 3/3] Address second Copilot review pass - CODE_OF_CONDUCT.md: add a heading and wrap the text; point the charter link to the current PDF location (the openvdb tsc/charter.md is now just a redirect stub). - MAINTAINERS.md: add trailing pipes / align the maintainer table for robust Markdown rendering. - CODEOWNERS: update the doc link from the legacy help.github.com URL to docs.github.com. - CONTRIBUTING.md: tidy spacing around the CLA parenthetical. - Add MAINTAINERS.md (was referenced by CONTRIBUTING.md but missing). Co-Authored-By: Claude Opus 4.8 Signed-off-by: Mark Harris --- CODEOWNERS | 2 +- CODE_OF_CONDUCT.md | 6 +++++- CONTRIBUTING.md | 2 +- MAINTAINERS.md | 18 ++++++++++++++++++ 4 files changed, 25 insertions(+), 3 deletions(-) create mode 100644 MAINTAINERS.md diff --git a/CODEOWNERS b/CODEOWNERS index 0d9f9d4..b007471 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,5 +1,5 @@ # fVDB CODEOWNERS -# See https://help.github.com/articles/about-codeowners/ +# See https://docs.github.com/articles/about-code-owners # for more info about CODEOWNERS file # # This file is kept identical across the fvdb-core, fvdb-reality-capture, diff --git a/CODE_OF_CONDUCT.md b/CODE_OF_CONDUCT.md index 5fa1cd3..79c4bc1 100644 --- a/CODE_OF_CONDUCT.md +++ b/CODE_OF_CONDUCT.md @@ -1 +1,5 @@ -All participants agree to abide by LF Projects Code of Conduct (as defined in the [charter](https://github.com/AcademySoftwareFoundation/openvdb/blob/master/tsc/charter.md)) available at https://lfprojects.org/policies/code-of-conduct/ +# Code of Conduct + +All participants agree to abide by the LF Projects Code of Conduct (as defined in +the [charter](https://github.com/AcademySoftwareFoundation/foundation/blob/main/project_charters/open-vdb_charter.pdf)), +available at . diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0f63bcd..67a455a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,7 @@ The contributor role is the starting role for anyone participating in the projec ### Process for becoming a contributor * Review the [coding standards](https://www.openvdb.org/documentation/doxygen/codingStyle.html) to ensure your contribution is in line with the project's coding and styling guidelines. -* Have a signed CLA on file ( see [below](#contributor-license-agreements) ) +* Have a signed CLA on file (see [below](#contributor-license-agreements)). * Submit your code as a PR with the appropriate [DCO sign-off](#commit-sign-off). * Have your submission approved by the [maintainer(s)](#maintainer) and merged into the codebase. diff --git a/MAINTAINERS.md b/MAINTAINERS.md new file mode 100644 index 0000000..8141253 --- /dev/null +++ b/MAINTAINERS.md @@ -0,0 +1,18 @@ + + + +# fVDB Maintainers + +The current fVDB maintainers are: + +| Name | Email | +| ------------------- | ------------------------- | +| Ken Museth | ken.museth@gmail.com | +| Jonathan Swartz | jonathan@jswartz.info | +| Francis Williams | francis@fwilliams.info | +| Mark Harris | mharris@nvidia.com | +| Matthew Cong | mcong@nvidia.com | +| Andrew Reidmeyer | areidmeyer@nvidia.com | +| Christopher Horvath | blackencino+git@gmail.com | +| Eftychios Sifakis | esifakis@nvidia.com | +| Petra Hapalova | phapalova@nvidia.com |