Skip to content

Unit test failure - TestWriteRollReadEOF #47

@peacedog123

Description

@peacedog123

Test locally and found:

=== RUN   TestWriteRollReadEOF
    diskqueue_test.go:78: INFO: DISKQUEUE(test_disk_queue_roll_readEOF1774672885): writeOne() opened /tmp/nsq-test-1774672885856807870650178824/test_disk_queue_roll_readEOF1774672885.diskqueue.000000.dat
    diskqueue_test.go:78: INFO: DISKQUEUE(test_disk_queue_roll_readEOF1774672885): readOne() opened /tmp/nsq-test-1774672885856807870650178824/test_disk_queue_roll_readEOF1774672885.diskqueue.000000.dat
    diskqueue_test.go:78: INFO: DISKQUEUE(test_disk_queue_roll_readEOF1774672885): writeOne() opened /tmp/nsq-test-1774672885856807870650178824/test_disk_queue_roll_readEOF1774672885.diskqueue.000001.dat
    diskqueue_test.go:78: ERROR: DISKQUEUE(test_disk_queue_roll_readEOF1774672885) reading at 1017 of /tmp/nsq-test-1774672885856807870650178824/test_disk_queue_roll_readEOF1774672885.diskqueue.000000.dat - EOF
    diskqueue_test.go:78: WARNING: DISKQUEUE(test_disk_queue_roll_readEOF1774672885) jump to next file and saving bad file as /tmp/nsq-test-1774672885856807870650178824/test_disk_queue_roll_readEOF1774672885.diskqueue.000000.dat.bad
    diskqueue_test.go:78: INFO: DISKQUEUE(test_disk_queue_roll_readEOF1774672885): readOne() opened /tmp/nsq-test-1774672885856807870650178824/test_disk_queue_roll_readEOF1774672885.diskqueue.000001.dat
    diskqueue_test.go:78: INFO: DISKQUEUE(test_disk_queue_roll_readEOF1774672885): closing
    diskqueue_test.go:78: INFO: DISKQUEUE(test_disk_queue_roll_readEOF1774672885): closing ... ioLoop
--- FAIL: TestWriteRollReadEOF (0.03s)
FAIL
exit status 1
FAIL    github.com/nsqio/go-diskqueue   0.129s

Seems we don't need to move to a bad file when meeting io.EOF error, any thought?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions