Skip to content

Commit a13a511

Browse files
Domantasclaude
andcommitted
[10b-SDK-2] record the gateway's own spelling of the public route
The SDK coverage matrix (sdks/tests/coverage/build_matrix.py) decides "implemented" by searching each SDK's source for the gateway's route string, verbatim and case-sensitive. The gateway declares the public file link as /{version}/files/public/{PublicId}/{Name*}; this SDK writes {publicId}/{name}, so the endpoint read as missing even though the method is there and tested. The route is now written out next to the method exactly as the gateway spells it. That is also the thing a reader wants when checking the two agree (knowledge.md K23 — an SDK is only covered when its routes are compared against the gateway's). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent e9bb82e commit a13a511

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

‎src/norbix_python/api/files.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,10 @@ def request_upload_url(self, files_integration_id: str, *, timeout: float | None
120120
def get_public_file(self, public_id: str, name: str, *, timeout: float | None = None, **request: Any) -> Any:
121121
"""GET /{version}/files/public/{publicId}/{name}
122122
123+
The gateway declares the route as /{version}/files/public/{PublicId}/{Name*} —
124+
written out here exactly as the gateway spells it, so the SDK coverage
125+
matrix can see that the two agree (knowledge.md K23).
126+
123127
Reads a file somebody made public.
124128
125129
**No sign-in and no project id.** The SDK deliberately sends no
@@ -269,6 +273,10 @@ async def request_upload_url(self, files_integration_id: str, *, timeout: float
269273
async def get_public_file(self, public_id: str, name: str, *, timeout: float | None = None, **request: Any) -> Any:
270274
"""GET /{version}/files/public/{publicId}/{name}
271275
276+
The gateway declares the route as /{version}/files/public/{PublicId}/{Name*} —
277+
written out here exactly as the gateway spells it, so the SDK coverage
278+
matrix can see that the two agree (knowledge.md K23).
279+
272280
Reads a file somebody made public.
273281
274282
**No sign-in and no project id.** The SDK deliberately sends no

0 commit comments

Comments
 (0)