From e41b328fd8ca69a0d4c037ed7e829c2960de27bf Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 18 Sep 2026 12:59:33 +0200 Subject: [PATCH 1/2] test: avoid call to `chmodSync` in `test-fs-cp-async-file-modes` Signed-off-by: Antoine du Hamel --- test/parallel/test-fs-cp-async-file-modes.mjs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/parallel/test-fs-cp-async-file-modes.mjs b/test/parallel/test-fs-cp-async-file-modes.mjs index 358f6c339b7b..2ccd2853dbc0 100644 --- a/test/parallel/test-fs-cp-async-file-modes.mjs +++ b/test/parallel/test-fs-cp-async-file-modes.mjs @@ -15,8 +15,7 @@ const modes = { suid: 0o4755, sgid: 0o2755, sticky: 0o1755, private: 0o600 }; const src = nextdir(); mkdirSync(src); for (const [name, mode] of Object.entries(modes)) { - writeFileSync(join(src, name), 'x'); - chmodSync(join(src, name), mode); + writeFileSync(join(src, name), 'x', { mode }); } const modesIn = (dir) => Object.fromEntries( Object.keys(modes).map((name) => [name, statSync(join(dir, name)).mode & 0o7777])); From 0fa81a4588834c4563997b0d0e9f29e878f67dd0 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 18 Sep 2026 13:09:51 +0200 Subject: [PATCH 2/2] fixup! test: avoid call to `chmodSync` in `test-fs-cp-async-file-modes` --- test/parallel/test-fs-cp-async-file-modes.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-fs-cp-async-file-modes.mjs b/test/parallel/test-fs-cp-async-file-modes.mjs index 2ccd2853dbc0..8aeaaceac4db 100644 --- a/test/parallel/test-fs-cp-async-file-modes.mjs +++ b/test/parallel/test-fs-cp-async-file-modes.mjs @@ -3,7 +3,7 @@ import { isWindows, skip } from '../common/index.mjs'; import { nextdir } from '../common/fs.js'; import assert from 'node:assert'; -import { chmodSync, cpSync, mkdirSync, statSync, writeFileSync, promises } from 'node:fs'; +import { cpSync, mkdirSync, statSync, writeFileSync, promises } from 'node:fs'; import { join } from 'node:path'; import tmpdir from '../common/tmpdir.js';