Skip to content

crypto: runtime-deprecate calling hmac.digest() multiple times #63800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
algojogacor wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

crypto: runtime-deprecate calling hmac.digest() multiple times #63800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/internal/crypto/hash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ const maybeEmitDeprecationWarning = getDeprecationWarningEmitter(
},
);

const maybeEmitHMACMultipleDigestDeprecationWarning =
getDeprecationWarningEmitter(
'DEP0208',
'Calling hmac.digest() multiple times without re-initialization is ' +
'deprecated and will throw an error in a future version.',
);

function Hash(algorithm, options) {
if (!new.target)
return new Hash(algorithm, options);
Expand Down Expand Up @@ -186,6 +193,7 @@ Hmac.prototype.digest = function digest(outputEncoding) {
const state = this[kState];

if (state[kFinalized]) {
maybeEmitHMACMultipleDigestDeprecationWarning();
const buf = Buffer.from('');
if (outputEncoding && outputEncoding !== 'buffer')
return buf.toString(outputEncoding);
Expand Down
Loading