From df4f85fb890fb864cb635835231ebe5cd0ca4cdb Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 5 Jun 2026 17:38:16 +0200 Subject: [PATCH 1/2] src: use C++14 deprecated attribute for `NODE_DEPRECATED` This has been standardized for a while, so there's no real reason not to just use it over compiler-specific alternatives. Signed-off-by: Anna Henningsen --- src/node.h | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/node.h b/src/node.h index 485037c72f31a6..872cfebe87f9be 100644 --- a/src/node.h +++ b/src/node.h @@ -111,15 +111,7 @@ #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS # define NODE_DEPRECATED(message, declarator) declarator #else // NODE_WANT_INTERNALS -# if NODE_CLANG_AT_LEAST(2, 9, 0) || NODE_GNUC_AT_LEAST(4, 5, 0) -# define NODE_DEPRECATED(message, declarator) \ - __attribute__((deprecated(message))) declarator -# elif defined(_MSC_VER) -# define NODE_DEPRECATED(message, declarator) \ - __declspec(deprecated) declarator -# else -# define NODE_DEPRECATED(message, declarator) declarator -# endif +# define NODE_DEPRECATED(message, declarator) [[deprecated(message)]] declarator #endif // Forward-declare libuv loop From bf3803b8430c16496b76a09b4e174a5e1cc0733b Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Fri, 5 Jun 2026 17:53:16 +0200 Subject: [PATCH 2/2] fixup! src: use C++14 deprecated attribute for `NODE_DEPRECATED` --- src/node.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node.h b/src/node.h index 872cfebe87f9be..32a9806ae84803 100644 --- a/src/node.h +++ b/src/node.h @@ -111,7 +111,7 @@ #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS # define NODE_DEPRECATED(message, declarator) declarator #else // NODE_WANT_INTERNALS -# define NODE_DEPRECATED(message, declarator) [[deprecated(message)]] declarator +#define NODE_DEPRECATED(message, declarator) [[deprecated(message)]] declarator #endif // Forward-declare libuv loop