sea: address review comments

Remove two comments in EnvironmentOptions::CheckOptions() that repeat
what the code and the error message already say, and move the note that
--vfs-load cannot be used in a single executable application out of the
"Worker threads" section, since it applies to every SEA.

Refs: #67223
Assisted-by: a coding agent
Signed-off-by: Manjeet Singh <024manjeetsingh@gmail.com>

Author: manusingh090

doc/api/single-executable-applications.md

@@ -223,6 +223,13 @@ The VFS supports the `node:fs` operations for reading files and directories.
 Since the SEA VFS is read-only, write operations fail with `EROFS`. See the
 [VFS documentation][] for the full list of supported operations.
 
+`useVfs` does for a single executable application what [`--vfs-load`][] does
+for `node`: the entry point is its `"main"`, and modules resolve against its
+own files. `--vfs-load` therefore cannot be used in a single executable
+application, whether or not it uses `useVfs`: `--build-sea` rejects it in
+`"execArgv"`, and the executable rejects it at startup when it comes from
+`--node-options` or from the `execArgv` of a worker.
+
 #### Loading modules from the VFS in a SEA
 
 When `useVfs` is enabled, the main script is executed from inside the
@@ -284,13 +291,6 @@ new Worker(path.join(__dirname, 'worker.js'));
 A virtual file system mounted with [`vfs.mount()`][] in one thread is not
 mounted in the others, so a worker cannot load a script from it.
 
-`useVfs` does for a single executable application what [`--vfs-load`][] does
-for `node`: the entry point is its `"main"`, and modules resolve against its
-own files. `--vfs-load` therefore cannot be used in a single executable
-application: `--build-sea` rejects it in `"execArgv"`, and the executable
-rejects it at startup when it comes from `--node-options` or from the
-`execArgv` of a worker.
-
 #### Serving the assets from a ZIP archive with `"vfsArchive"`
 
 Instead of listing individual `"assets"`, the configuration can point

src/node_options.cc

@@ -320,14 +320,8 @@ void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors,
   }
 
 #ifndef DISABLE_SINGLE_EXECUTABLE_APPLICATION
-  // "useVfs" is the --vfs-load of a SEA, whichever provider serves the VFS,
-  // and takes the mount point reserved for the --vfs-load source.
   sea_vfs = sea::IsSingleExecutable() &&
             sea::FindSingleExecutableResource().use_vfs();
-  // The entry point of a SEA is its "main", and resolving modules against its
-  // files is what "useVfs" does, so --vfs-load has nothing to do in any SEA.
-  // Accepting it from --node-options would also let whoever runs the binary
-  // change what it resolves, which is why it is disallowed in NODE_OPTIONS.
   if (!vfs_load_source.empty() && sea::IsSingleExecutable()) {
     errors->push_back(
         "--vfs-load cannot be used in a single executable application");