|
| 1 | +// Flags: --js-immutable-arraybuffer |
| 2 | +'use strict'; |
| 3 | + |
| 4 | +// Reads must not modify an immutable ArrayBuffer created by transferring a |
| 5 | +// registered onread buffer. |
| 6 | + |
| 7 | +const common = require('../common'); |
| 8 | +const assert = require('node:assert'); |
| 9 | +const { once } = require('node:events'); |
| 10 | +const net = require('node:net'); |
| 11 | +const { test } = require('node:test'); |
| 12 | + |
| 13 | +for (const mode of ['before first read', 'between reads', 'replacement buffer']) { |
| 14 | + test(`onread buffer transferred ${mode}`, async (t) => { |
| 15 | + const backing = new ArrayBuffer(8); |
| 16 | + new Uint8Array(backing).fill(42); |
| 17 | + const buffer = mode === 'replacement buffer' ? |
| 18 | + Buffer.from(backing, 2, 4) : new Uint8Array(backing, 2, 4); |
| 19 | + const firstBuffer = new Uint8Array(1); |
| 20 | + const connections = new Set(); |
| 21 | + let peer; |
| 22 | + let socket; |
| 23 | + let immutable; |
| 24 | + let expected; |
| 25 | + let factoryCalls = 0; |
| 26 | + let readError; |
| 27 | + const closed = Promise.withResolvers(); |
| 28 | + |
| 29 | + const server = net.createServer(common.mustCall((connection) => { |
| 30 | + peer = connection; |
| 31 | + connection.on('error', (error) => { |
| 32 | + if (error.code !== 'ECONNRESET') throw error; |
| 33 | + }); |
| 34 | + if (mode === 'before first read') { |
| 35 | + connection.end('test'); |
| 36 | + } else { |
| 37 | + connection.write('a'); |
| 38 | + } |
| 39 | + })); |
| 40 | + server.on('connection', (connection) => { |
| 41 | + connections.add(connection); |
| 42 | + connection.on('close', () => connections.delete(connection)); |
| 43 | + }); |
| 44 | + t.after(async () => { |
| 45 | + socket?.destroy(); |
| 46 | + for (const connection of connections) connection.destroy(); |
| 47 | + if (server.listening) { |
| 48 | + await new Promise((resolve) => server.close(resolve)); |
| 49 | + } |
| 50 | + }); |
| 51 | + server.listen(0, '127.0.0.1'); |
| 52 | + await once(server, 'listening'); |
| 53 | + |
| 54 | + function transfer() { |
| 55 | + expected = [...new Uint8Array(backing)]; |
| 56 | + immutable = backing.transferToImmutable(); |
| 57 | + assert.strictEqual(buffer.byteLength, 0); |
| 58 | + assert.strictEqual(immutable.immutable, true); |
| 59 | + } |
| 60 | + |
| 61 | + socket = net.connect({ |
| 62 | + host: '127.0.0.1', |
| 63 | + port: server.address().port, |
| 64 | + onread: { |
| 65 | + buffer: mode === 'replacement buffer' ? common.mustCall(() => { |
| 66 | + return ++factoryCalls === 1 ? firstBuffer : buffer; |
| 67 | + }, 2) : buffer, |
| 68 | + callback: common.mustCall((nread, view) => { |
| 69 | + try { |
| 70 | + if (immutable !== undefined) { |
| 71 | + assert.deepStrictEqual([...new Uint8Array(immutable)], expected); |
| 72 | + assert.fail('onread called after the buffer was transferred'); |
| 73 | + } |
| 74 | + assert.strictEqual(nread, 1); |
| 75 | + assert.strictEqual(view, mode === 'replacement buffer' ? firstBuffer : buffer); |
| 76 | + assert.strictEqual(view[0], 97); |
| 77 | + if (mode === 'replacement buffer') { |
| 78 | + // The factory's next view is registered after this callback. |
| 79 | + setImmediate(common.mustCall(() => { |
| 80 | + transfer(); |
| 81 | + peer.end('test'); |
| 82 | + })); |
| 83 | + } else { |
| 84 | + transfer(); |
| 85 | + peer.end('test'); |
| 86 | + } |
| 87 | + } catch (error) { |
| 88 | + closed.reject(error); |
| 89 | + return false; |
| 90 | + } |
| 91 | + }, mode === 'before first read' ? 0 : 1), |
| 92 | + }, |
| 93 | + }); |
| 94 | + socket.on('data', common.mustNotCall()); |
| 95 | + socket.on('end', common.mustNotCall()); |
| 96 | + socket.on('error', common.mustCall((error) => { |
| 97 | + readError = error; |
| 98 | + })); |
| 99 | + socket.on('close', common.mustCall(closed.resolve)); |
| 100 | + if (mode === 'before first read') transfer(); |
| 101 | + assert.strictEqual(await closed.promise, true); |
| 102 | + assert.strictEqual(readError.code, 'EINVAL'); |
| 103 | + assert.strictEqual(readError.syscall, 'read'); |
| 104 | + assert.deepStrictEqual([...new Uint8Array(immutable)], expected); |
| 105 | + }); |
| 106 | +} |
| 107 | + |
| 108 | +test('onread factory replaces buffers transferred after each read', async (t) => { |
| 109 | + const message = Buffer.from('test'); |
| 110 | + const chunks = []; |
| 111 | + const closed = Promise.withResolvers(); |
| 112 | + let peer; |
| 113 | + let socket; |
| 114 | + |
| 115 | + const server = net.createServer(common.mustCall((connection) => { |
| 116 | + peer = connection; |
| 117 | + connection.on('error', (error) => { |
| 118 | + if (error.code !== 'ECONNRESET') throw error; |
| 119 | + }); |
| 120 | + connection.end(message); |
| 121 | + })); |
| 122 | + t.after(async () => { |
| 123 | + socket?.destroy(); |
| 124 | + peer?.destroy(); |
| 125 | + if (server.listening) { |
| 126 | + await new Promise((resolve) => server.close(resolve)); |
| 127 | + } |
| 128 | + }); |
| 129 | + server.listen(0, '127.0.0.1'); |
| 130 | + await once(server, 'listening'); |
| 131 | + |
| 132 | + socket = net.connect({ |
| 133 | + host: '127.0.0.1', |
| 134 | + port: server.address().port, |
| 135 | + onread: { |
| 136 | + buffer: common.mustCall(() => new Uint8Array(1), message.length + 1), |
| 137 | + callback: common.mustCall((nread, view) => { |
| 138 | + try { |
| 139 | + assert.strictEqual(nread, 1); |
| 140 | + const immutable = view.buffer.transferToImmutable(); |
| 141 | + assert.strictEqual(view.byteLength, 0); |
| 142 | + assert.strictEqual(immutable.immutable, true); |
| 143 | + chunks.push(immutable); |
| 144 | + } catch (error) { |
| 145 | + closed.reject(error); |
| 146 | + return false; |
| 147 | + } |
| 148 | + }, message.length), |
| 149 | + }, |
| 150 | + }); |
| 151 | + socket.on('data', common.mustNotCall()); |
| 152 | + socket.on('end', common.mustCall()); |
| 153 | + socket.on('error', closed.reject); |
| 154 | + socket.on('close', common.mustCall(closed.resolve)); |
| 155 | + assert.strictEqual(await closed.promise, false); |
| 156 | + assert.deepStrictEqual(chunks.flatMap((chunk) => [...new Uint8Array(chunk)]), [...message]); |
| 157 | +}); |
0 commit comments