From 328aafe2b0168c1265528405d340ffeefe466fe5 Mon Sep 17 00:00:00 2001
From: kristian-zendato <kristian.zendato@nextcloud.com>
Date: Thu, 17 Sep 2026 04:14:48 +0000
Subject: [PATCH 1/5] fix: update recipient emails in HTML list

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
---
 .../NewFileRequestDialogFinish.vue            | 47 ++++++++++---------
 1 file changed, 26 insertions(+), 21 deletions(-)

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue
index fc01d5513b680..c4a034e9385e4 100644
--- a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue
+++ b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue
@@ -40,24 +40,27 @@
 				@focusout.native="addNewEmail" />
 
 			<!-- Email list -->
-			<div v-if="emails.length > 0" class="file-request-dialog__emails">
-				<NcChip
-					v-for="mail in emails"
-					:key="mail"
-					:aria-label-close="t('files_sharing', 'Remove email')"
-					:text="mail"
-					@close="$emit('remove-email', mail)">
-					<template #icon>
-						<NcAvatar
-							disable-menu
-							disable-tooltip
-							:display-name="mail"
-							is-no-user
-							hide-status
-							:size="24" />
-					</template>
-				</NcChip>
-			</div>
+			<ul
+				v-if="emails.length > 0"
+				class="file-request-dialog__emails"
+				:aria-label="t('files_sharing', 'Recipient emails')">
+				<li v-for="mail in emails" :key="mail">
+					<NcChip
+						:aria-label-close="t('files_sharing', 'Remove email')"
+						:text="mail"
+						@close="$emit('remove-email', mail)">
+						<template #icon>
+							<NcAvatar
+								disable-menu
+								disable-tooltip
+								:display-name="mail"
+								is-no-user
+								hide-status
+								:size="24" />
+						</template>
+					</NcChip>
+				</li>
+			</ul>
 		</template>
 	</div>
 </template>
@@ -229,14 +232,16 @@ export default defineComponent({
 </script>
 
 <style scoped>
-.input-field,
-.file-request-dialog__emails {
+.input-field {
 	margin-top: var(--margin);
 }
 
 .file-request-dialog__emails {
 	display: flex;
-	gap: var(--default-grid-baseline);
 	flex-wrap: wrap;
+	gap: var(--default-grid-baseline);
+	list-style: none;
+	margin-block: var(--margin) 0;
+	padding-inline: 0;
 }
 </style>

From 81fb734760df69f49d015d9c21dfe939ba95f04e Mon Sep 17 00:00:00 2001
From: kristian-zendato <kristian.zendato@nextcloud.com>
Date: Thu, 17 Sep 2026 04:23:48 +0000
Subject: [PATCH 2/5] fix: add aria label to close button on recipient email
 chip

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
---
 .../NewFileRequestDialog/NewFileRequestDialogFinish.vue         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue
index c4a034e9385e4..997e5884fa5f1 100644
--- a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue
+++ b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogFinish.vue
@@ -46,7 +46,7 @@
 				:aria-label="t('files_sharing', 'Recipient emails')">
 				<li v-for="mail in emails" :key="mail">
 					<NcChip
-						:aria-label-close="t('files_sharing', 'Remove email')"
+						:aria-label-close="t('files_sharing', 'Remove email: {email}', { email: mail })"
 						:text="mail"
 						@close="$emit('remove-email', mail)">
 						<template #icon>

From 8b5125c0b1251d29804eaedd0803b8f06ecc3770 Mon Sep 17 00:00:00 2001
From: kristian-zendato <kristian.zendato@nextcloud.com>
Date: Thu, 17 Sep 2026 07:47:56 +0000
Subject: [PATCH 3/5] fix: link labels to form fields on create file request UI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
---
 .../NewFileRequestDialogDatePassword.vue      |  1 -
 .../NewFileRequestDialogIntro.vue             | 21 ++++++++++++++++---
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogDatePassword.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogDatePassword.vue
index b2505c8e06f10..482919ff173b5 100644
--- a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogDatePassword.vue
+++ b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogDatePassword.vue
@@ -27,7 +27,6 @@
 				v-if="expirationDate !== null"
 				id="file-request-dialog-expirationDate"
 				:disabled="disabled"
-				:hide-label="true"
 				:label="t('files_sharing', 'Expiration date')"
 				:max="maxDate"
 				:min="minDate"
diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
index d4602872afe18..5cdf0a46827d1 100644
--- a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
+++ b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
@@ -8,9 +8,12 @@
 		<!-- Request label -->
 		<fieldset class="file-request-dialog__label" data-cy-file-request-dialog-fieldset="label">
 			<legend>
-				{{ t('files_sharing', 'What are you requesting?') }}
+				<label class="file-request-dialog__legend-label" for="file-request-dialog-label">
+					{{ t('files_sharing', 'What are you requesting?') }}
+				</label>
 			</legend>
 			<NcTextField
+				id="file-request-dialog-label"
 				:model-value="label"
 				:disabled="disabled"
 				:label="t('files_sharing', 'Request subject')"
@@ -23,9 +26,12 @@
 		<!-- Request destination -->
 		<fieldset class="file-request-dialog__destination" data-cy-file-request-dialog-fieldset="destination">
 			<legend>
-				{{ t('files_sharing', 'Where should these files go?') }}
+				<label class="file-request-dialog__legend-label" for="file-request-dialog-destination">
+					{{ t('files_sharing', 'Where should these files go?') }}
+				</label>
 			</legend>
 			<NcTextField
+				id="file-request-dialog-destination"
 				:model-value="destination"
 				:disabled="disabled"
 				:label="t('files_sharing', 'Upload destination')"
@@ -53,9 +59,12 @@
 		<!-- Request note -->
 		<fieldset class="file-request-dialog__note" data-cy-file-request-dialog-fieldset="note">
 			<legend>
-				{{ t('files_sharing', 'Add a note') }}
+				<label class="file-request-dialog__legend-label" for="file-request-dialog-note">
+					{{ t('files_sharing', 'Add a note') }}
+				</label>
 			</legend>
 			<NcTextArea
+				id="file-request-dialog-note"
 				:model-value="note"
 				:disabled="disabled"
 				:label="t('files_sharing', 'Note for recipient')"
@@ -168,6 +177,12 @@ export default defineComponent({
 </script>
 
 <style scoped>
+.file-request-dialog__legend-label {
+	font: inherit;
+	color: inherit;
+	cursor: pointer;
+}
+
 .file-request-dialog__note :deep(textarea) {
 	width: 100% !important;
 	min-height: 80px;

From 5a0153ade41852f45c2828fc750c1ce1a2249e8a Mon Sep 17 00:00:00 2001
From: kristian-zendato <kristian.zendato@nextcloud.com>
Date: Thu, 17 Sep 2026 07:57:27 +0000
Subject: [PATCH 4/5] fix: make upload destination selectable via keyboard on
 create file request UI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
---
 .../NewFileRequestDialogIntro.vue             | 25 +++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
index 5cdf0a46827d1..7f27c4d3df85b 100644
--- a/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
+++ b/apps/files_sharing/src/components/NewFileRequestDialog/NewFileRequestDialogIntro.vue
@@ -43,9 +43,10 @@
 				trailing-button-icon="undo"
 				:trailing-button-label="t('files_sharing', 'Revert to default')"
 				name="destination"
+				aria-haspopup="dialog"
 				@click="onPickDestination"
-				@keypress.prevent.stop="/* prevent typing in the input, we use the picker */"
-				@paste.prevent.stop="/* prevent pasting in the input, we use the picker */"
+				@keydown="onDestinationKeydown"
+				@paste.prevent.stop
 				@trailing-button-click="$emit('update:destination', '')">
 				<IconFolder :size="18" />
 			</NcTextField>
@@ -147,6 +148,22 @@ export default defineComponent({
 	},
 
 	methods: {
+		onDestinationKeydown(event: KeyboardEvent) {
+			if (event.key === 'Enter' || event.key === ' ') {
+				event.preventDefault()
+				this.onPickDestination()
+				return
+			}
+
+			// Destination is chosen in the picker, not by editing this field
+			if (event.ctrlKey || event.metaKey || event.altKey) {
+				return
+			}
+			if (event.key.length === 1 || event.key === 'Backspace' || event.key === 'Delete') {
+				event.preventDefault()
+			}
+		},
+
 		onPickDestination() {
 			const filepicker = getFilePickerBuilder(t('files_sharing', 'Select a destination'))
 				.addMimeTypeFilter('httpd/unix-directory')
@@ -183,6 +200,10 @@ export default defineComponent({
 	cursor: pointer;
 }
 
+.file-request-dialog__destination :deep(.input-field__input) {
+	cursor: pointer;
+}
+
 .file-request-dialog__note :deep(textarea) {
 	width: 100% !important;
 	min-height: 80px;

From 36d410a849a96cba1730e80b81c51093f85ba910 Mon Sep 17 00:00:00 2001
From: kristian-zendato <kristian.zendato@nextcloud.com>
Date: Thu, 17 Sep 2026 08:09:44 +0000
Subject: [PATCH 5/5] fix: focus on New button after finishing create file
 request UI

Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
---
 apps/files_sharing/src/components/NewFileRequestDialog.vue | 5 +++++
 apps/files_sharing/src/files_newMenu/newFileRequest.ts     | 4 +++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/apps/files_sharing/src/components/NewFileRequestDialog.vue b/apps/files_sharing/src/components/NewFileRequestDialog.vue
index 24de10b725e9b..5a03fcc0e0d6b 100644
--- a/apps/files_sharing/src/components/NewFileRequestDialog.vue
+++ b/apps/files_sharing/src/components/NewFileRequestDialog.vue
@@ -9,6 +9,7 @@
 		data-cy-file-request-dialog
 		:close-on-click-outside="false"
 		:name="currentStep !== STEP.LAST ? t('files_sharing', 'Create a file request') : t('files_sharing', 'File request created')"
+		:set-return-focus="returnFocusTarget"
 		size="normal"
 		@closing="onCancel">
 		<!-- Header -->
@@ -226,6 +227,10 @@ export default defineComponent({
 	},
 
 	methods: {
+		returnFocusTarget(): HTMLElement | null {
+			return document.querySelector<HTMLElement>('[data-cy-upload-picker] button')
+		},
+
 		onPageNext() {
 			const form = this.$refs.form as HTMLFormElement
 
diff --git a/apps/files_sharing/src/files_newMenu/newFileRequest.ts b/apps/files_sharing/src/files_newMenu/newFileRequest.ts
index d29a977b05b9b..664b09b1e46c6 100644
--- a/apps/files_sharing/src/files_newMenu/newFileRequest.ts
+++ b/apps/files_sharing/src/files_newMenu/newFileRequest.ts
@@ -35,9 +35,11 @@ export const entry: NewMenuEntry = {
 		return sharingConfig.isPublicShareAllowed
 	},
 	async handler(context: Folder, content: Node[]) {
-		spawnDialog(NewFileRequestDialogVue, {
+		await spawnDialog(NewFileRequestDialogVue, {
 			context,
 			content,
 		})
+		// The menu item that opened the dialog is gone; send focus back to New
+		document.querySelector<HTMLElement>('[data-cy-upload-picker] button')?.focus()
 	},
 }