chore(docs): Apply remining requests from PR #2217#2231
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Warning Review limit reached
More reviews will be available in 32 minutes and 46 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR replaces the ChangesFeatured ENS Node Integrators Component Replacement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR applies follow-up changes requested in PR #2217, renaming the
Confidence Score: 5/5Safe to merge — purely a rename/refactor with no logic changes beyond the two previously requested fixes. All changed files are UI/presentation layer only. The two previously flagged issues (misplaced key prop and unguarded findIndex returning -1) are both correctly addressed, no stale references to the old naming remain anywhere in the source tree, and the responsive layout logic is straightforward. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[FeaturedENSNodeIntegrators] --> B{findIndex\n'Official ENSv2 Explorer'}
B -->|found| C[splitIntegratorsAt = index]
B -->|not found / -1| D[splitIntegratorsAt = ceil length/2]
C --> E[topIntegratorsRow = slice 0..split]
D --> E
C --> F[bottomIntegratorsRow = slice split..end]
D --> F
E --> G[DisplayENSNodeIntegrators\nall items — shown below 1250px]
E --> H[DisplayENSNodeIntegrators\ntopRow — shown above 1250px]
F --> I[DisplayENSNodeIntegrators\nbottomRow — shown above 1250px]
Reviews (4): Last reviewed commit: "Final tweaks after UI double-check" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/ensnode.io/src/components/organisms/FeaturedENSNodeIntegrators/index.tsx`:
- Around line 53-59: The mapped list currently sets the React key on the nested
<a> instead of the mapped root; in the integrators.map(...) callback move the
key prop from the <a> element to the outer <Tooltip> component (e.g.,
key={`featured-ensnode-integrator=${member.name}`} on <Tooltip>), remove the key
from the <a>, and keep other props like aria-label on the <a> unchanged so React
reconciliation uses the Tooltip as the mapped top-level element.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4a292f32-81fb-41ba-9a2a-8a568428bcc9
📒 Files selected for processing (19)
docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/AnticaptureLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/AtlasLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/BlockfulLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSLabsLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSTestEnvLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSVisionLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSv2AppLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSv2ExplorerLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSvolutionLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/EnscribeLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/EthIdLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/EthereumCommentsProtocolLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/GrailsLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/JustaNameLogo.tsxdocs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/NamespaceLogo.tsxdocs/ensnode.io/src/components/organisms/ENSEcosystemMembers/index.tsxdocs/ensnode.io/src/components/organisms/FeaturedENSNodeIntegrators/index.tsxdocs/ensnode.io/src/components/organisms/FeaturedENSNodeIntegrators/integrators-collection.tsxdocs/ensnode.io/src/pages/index.astro
💤 Files with no reviewable changes (1)
- docs/ensnode.io/src/components/organisms/ENSEcosystemMembers/index.tsx
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR updates the ensnode.io landing page “icon wall” by replacing the previous ENSEcosystemMembers section with a new FeaturedENSNodeIntegrators component and a refreshed set of SVG logos, reflecting follow-up requests from PR #2217.
Changes:
- Swap the home page section from
ENSEcosystemMemberstoFeaturedENSNodeIntegrators. - Introduce a new
FeaturedENSNodeIntegratorsReact component with responsive row-splitting behavior. - Add a new collection of “featured integrator” SVG logo components and update the integrator data source.
Reviewed changes
Copilot reviewed 4 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/ensnode.io/src/pages/index.astro | Switches homepage section to render FeaturedENSNodeIntegrators. |
| docs/ensnode.io/src/components/organisms/FeaturedENSNodeIntegrators/index.tsx | New icon-wall UI and responsive row splitting. |
| docs/ensnode.io/src/components/organisms/FeaturedENSNodeIntegrators/integrators-collection.tsx | New integrator metadata list and icon mapping. |
| docs/ensnode.io/src/components/organisms/ENSEcosystemMembers/index.tsx | Removes prior icon-wall component implementation. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/AnticaptureLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/AtlasLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/BlockfulLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/EnscribeLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSLabsLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSTestEnvLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSv2AppLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSv2ExplorerLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSVisionLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/ENSvolutionLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/EthereumCommentsProtocolLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/EthIdLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/GrailsLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/JustaNameLogo.tsx | Adds new featured integrator SVG logo. |
| docs/ensnode.io/src/components/atoms/logos/featured-ensnode-integrators/NamespaceLogo.tsx | Adds new featured integrator SVG logo. |
Comments suppressed due to low confidence (1)
docs/ensnode.io/src/components/organisms/FeaturedENSNodeIntegrators/integrators-collection.tsx:22
- This file uses
React.SVGPropsin types but doesn’t import theReacttype namespace. Other icon/logo components in this codebase importtype Reactexplicitly (e.g.docs/ensnode.io/src/components/atoms/logos/ENSNodeLogoDark.tsx:1).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…/chore/2217-follow-up-fixes
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 19 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/ensnode.io/src/components/organisms/FeaturedENSNodeIntegrators/integrators-collection.tsx:21
React.SVGPropsis referenced in a type position, but this module doesn’t import theReacttype namespace (unlike other icons/logos in the docs codebase). This is likely to fail typechecking/linting with “Cannot find namespace 'React'”. Import the React types or switch toSVGPropsto avoid relying on theReactnamespace.
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@Y3drk All looks good, thank you! 🫡
Lite PR → Apply remining requests from PR #2217
Summary
icon wallon the ensnode.io landing page #2217Why
icon wallon the ensnode.io landing page #2217 (review)Testing
lintcommand locally to ensure that the migration didn't break anything, and later confirmed that in our CI workflowNotes for Reviewer (Optional)
Pre-Review Checklist (Blocking)