From 0d7c89bbc6615716e336c8c7fc4c6e608b97d7a4 Mon Sep 17 00:00:00 2001 From: Patrick <320190286+muellerei@users.noreply.github.com> Date: Sat, 3 Oct 2026 05:39:34 +0200 Subject: [PATCH] Record in the changelog that renaming inbound_count went unnoticed The only test of get-page-stats' inbound_count checked its absence after a failed read, and none expected it present; renaming it left the suite green. Also notes the three negative message checks that could no longer fire, with how they were found. --- CHANGELOG.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad77178..dfb563e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -235,6 +235,23 @@ file carries most of the reasoning behind the tool. task, fails the new one). The empty-graph smoke test now requires exit 0 and JSON where it allowed `SystemExit`. No command changed. +- The suite would not have noticed `get-page-stats` losing its `inbound_count` + field. Its only test looked for the field's absence after a failed read + (`"inbound_count"` not in stdout), and no test expected it present: renaming + it left all 3265 tests green. A test now reads the stats when the scan can + read every page and expects the field and its value. + - Three more checks asserted that a message is absent after the message had + gone, so they could not fail: "Could not find or create" (removed with the + top-level fallback) and "cannot preserve" (removed when top-level blocks + began to keep their ids), the latter in two tests. The first was redundant + next to the JSON parse of stderr and is removed; the others now look for + the dropped-`id::` note, whose wording their sibling tests pin. + - Found by listing the 154 checks of the form `"text" not in …` and + asking, for each, whether the code still emits the text and whether any + test expects it. Checked by mutation: printing the dropped-id note despite + `--keep-ids` passes the old assertions and fails the new ones in all eight + cases. No command changed. + ## [0.16.0] - 2026-09-26 Every write is now proven, and none overwrites a block you are editing.