[Bug]: override with approve of one version from multiple would approve all versions

[ioanarusiczki]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

1. Make an addon with multiple versions
2. Reject all versions
3. Override with approve but select a single version

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/644042
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/643987

What did you expect to happen?

All versions are approved instead of only one.

┆Issue is synchronized with this Jira Task

[eviljeff]

@ioanarusiczki I can replicate this locally, but I'm unsure what you think is the expected outcome.

This is the scenario, for what I understand:

• Add-on with versions 1,2,3, presumably none of them rejected, or you wouldn't be rejecting that version, so I'm assuming all Approved (possibly the latest awaiting review)
• decision made with policy that rejects versions, and all versions selected, so all rejected
• new decision, with override of previous decision, but selecting version,say 1, and not selecting 2 and 3.
• overridden decision is reversed - you are replacing it with this new decision - so versions 1,2,3 are returned to their previous statuses (all approved?), and then the new decision applied (version 1 approved)

So what were you "trying to do, as a reviewer"?

• If it was to correct a previous bad decision where you meant to approve, rather than reject, then the bad decision is reversed as expected?
• If the previous decision was bad because you didn't want to reject all of the versions, then the new decision would be to reject the versions again, with a different selection of versions? (which would lead to the unselected versions becoming approved, as they were before the rejection)