[Bug]: None days instead of 30 on the first email sent for a delay rejection used to override

[ioanarusiczki]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

From #16354 (comment)

1. From a review page use a negative action for an addon/version
2. Override the initial decision with a delay rejection

What did you expect to happen?

Email sent

┆Issue is synchronized with this Jira Task

[ioanarusiczki]

I see the email looks good when I didn't use the delay reject for an override.

[eviljeff]

Fwiw, I think this is due to the logic in ContentDecision.send_notifications - it relies on self.activities.last(), which usually gives us the ActivityLog instance containing metadata we can use to populate the email notification. Except when it's an override there will be two ActivityLog instances - one for the reversal, and one for the new action and .last() gives us the reversal, not the override (and the reversal could be lacking some action specific metadata that the override activity would have, such as delay days for delayed rejections).