Repository navigation
Commit d280b57
committed
Strip stdio frames as bytes
## Motivation and Context
`StdioTransport` reads `$stdin` as UTF-8 and strips each frame before parsing it, in the read loop of `#open`
and in the loop of `#send_request` that reads the client's reply. `String#strip` raises for a UTF-8 string holding
an invalid byte at either end on every supported Ruby, and anywhere in it from Ruby 3.2 on,
and nothing rescued it there: one frame such as `\xff[]`, or a request with an invalid byte in a string value,
ended the read loop and the server process, before the parser could answer it. JSON text must be UTF-8
(RFC 8259, section 8.1), and the Python SDK replaces such bytes on its stdio streams instead of stopping.
Frames are now stripped as bytes. A frame that is not JSON gets the `-32700` parse error any other unparsable frame gets,
and a value holding such a byte reaches the handlers, which serve or refuse it as over HTTP.
## How Has This Been Tested?
`test/mcp/server/transports/stdio_transport_test.rb`: a frame starting with an invalid byte, a frame holding one in a value,
and a client reply holding one in a value. Against the previous library all three raise from `String#strip`
(the value tests from Ruby 3.2 on).
## Breaking Changes
None.1 parent 6d7b3c4 commit d280b57
2 files changed
Lines changed: 82 additions & 2 deletions
File tree
- lib/mcp/server/transports
- test/mcp/server/transports
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| |||
178 | 178 | | |
179 | 179 | | |
180 | 180 | | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
181 | 189 | | |
182 | 190 | | |
183 | 191 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
253 | 296 | | |
254 | 297 | | |
255 | 298 | | |
| |||
319 | 362 | | |
320 | 363 | | |
321 | 364 | | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
322 | 394 | | |
323 | 395 | | |
324 | 396 | | |
| |||
0 commit comments