From 245f18415c10a000e4fdb9ba13d73b680633ccdf Mon Sep 17 00:00:00 2001 From: Andrzej Ochodek Date: Fri, 30 Oct 2026 17:06:43 +0100 Subject: [PATCH 1/2] Fix the ValidationError snippet in the Core README The "failed result" example called a ValidationError constructor that doesn't exist, so it didn't compile; it moved from the root README into the packed Core README in #99. It now uses the real constructor, with a camelCase rule name like the library's validators and no value, so no identifier lands in the error's metadata (ADR-0003). Co-Authored-By: Claude Opus 5.5 --- src/OpenUrzednik.Core/README.md | 2 +- src/OpenUrzednik.Core/README.pl.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/OpenUrzednik.Core/README.md b/src/OpenUrzednik.Core/README.md index 1191ce4..0d03aa1 100644 --- a/src/OpenUrzednik.Core/README.md +++ b/src/OpenUrzednik.Core/README.md @@ -31,7 +31,7 @@ using OpenUrzednik.Core; using OpenUrzednik.Core.Errors; using OpenUrzednik.Core.Exceptions; -OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.")); +OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.", ruleName: "NipChecksum", name: "nip", value: null)); try { diff --git a/src/OpenUrzednik.Core/README.pl.md b/src/OpenUrzednik.Core/README.pl.md index 6480419..83cd731 100644 --- a/src/OpenUrzednik.Core/README.pl.md +++ b/src/OpenUrzednik.Core/README.pl.md @@ -31,7 +31,7 @@ using OpenUrzednik.Core; using OpenUrzednik.Core.Errors; using OpenUrzednik.Core.Exceptions; -OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.")); +OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.", ruleName: "NipChecksum", name: "nip", value: null)); try { From d6402f08123bbc44dc25960726061e1a0ad5420f Mon Sep 17 00:00:00 2001 From: Andrzej Ochodek Date: Fri, 30 Oct 2026 17:07:10 +0100 Subject: [PATCH 2/2] Use a camelCase rule name in the Core README snippet Matches the library's validators (topCount, iso4217, ...). The previous commit's edit was skipped by a case-insensitive check in my script. Co-Authored-By: Claude Opus 5.5 --- src/OpenUrzednik.Core/README.md | 2 +- src/OpenUrzednik.Core/README.pl.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/OpenUrzednik.Core/README.md b/src/OpenUrzednik.Core/README.md index 0d03aa1..aa2246b 100644 --- a/src/OpenUrzednik.Core/README.md +++ b/src/OpenUrzednik.Core/README.md @@ -31,7 +31,7 @@ using OpenUrzednik.Core; using OpenUrzednik.Core.Errors; using OpenUrzednik.Core.Exceptions; -OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.", ruleName: "NipChecksum", name: "nip", value: null)); +OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.", ruleName: "nipChecksum", name: "nip", value: null)); try { diff --git a/src/OpenUrzednik.Core/README.pl.md b/src/OpenUrzednik.Core/README.pl.md index 83cd731..f6ca199 100644 --- a/src/OpenUrzednik.Core/README.pl.md +++ b/src/OpenUrzednik.Core/README.pl.md @@ -31,7 +31,7 @@ using OpenUrzednik.Core; using OpenUrzednik.Core.Errors; using OpenUrzednik.Core.Exceptions; -OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.", ruleName: "NipChecksum", name: "nip", value: null)); +OpenUrzednikResult failed = OpenUrzednikResult.Failure(new ValidationError("NIP is invalid.", ruleName: "nipChecksum", name: "nip", value: null)); try {