You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both imports are inside `try/except Exception` blocks that fall through to empty specs / generic defaults, so the missing modules are masked at runtime — the broken branches are silently skipped.
Tracked from PR review (typecheck cleanup PR) — silenced for the type-check pass with `# type: ignore[import-not-found]` while we decide whether to:
Reintroduce `inference.onnx_config.{input_generator,patterns}` (if the integration was meant to land in a follow-up that never did), or
Delete the dead try-blocks and let the function unconditionally return its fallback (`{}` for input specs, generic outputs).
Suggested action
Option 2 is the pragmatic cleanup unless there's a known plan to ship the `inference.onnx_config` subpackage. Option 1 needs design context this review doesn't have.
Reference
Skill: `modelkit-typechecking` — Pattern "Surface every `# type: ignore[import-not-found]`"
Related: bug: non exist code are imported #824 (similar dead-module pattern in `core/unified_optimizer.py` and `core/universal_hierarchy_exporter.py`)
Context
`src/winml/modelkit/export/htp/config_generator.py` references a `winml.modelkit.inference.onnx_config` subpackage that does not exist in the repo:
Both imports are inside `try/except Exception` blocks that fall through to empty specs / generic defaults, so the missing modules are masked at runtime — the broken branches are silently skipped.
Tracked from PR review (typecheck cleanup PR) — silenced for the type-check pass with `# type: ignore[import-not-found]` while we decide whether to:
Suggested action
Option 2 is the pragmatic cleanup unless there's a known plan to ship the `inference.onnx_config` subpackage. Option 1 needs design context this review doesn't have.
Reference