chore: return Java locator code from toString() only for normalized locators

Author: yury-s

playwright/src/main/java/com/microsoft/playwright/impl/LocalUtils.java

@@ -78,12 +78,4 @@ public Pattern globToRegex(String glob, String baseURL, boolean webSocketUrl) {
     String regex = json.get("regex").getAsString();
     return Pattern.compile(regex);
   }
-
-  String asLocatorDescription(String selector) {
-    JsonObject params = new JsonObject();
-    params.addProperty("selector", selector);
-    params.addProperty("sdkLanguage", "java");
-    JsonObject json = sendMessage("asLocatorDescription", params, NO_TIMEOUT).getAsJsonObject();
-    return json.get("description").getAsString();
-  }
 }

playwright/src/main/java/com/microsoft/playwright/impl/LocatorImpl.java

@@ -695,14 +695,14 @@ public Locator within(Locator locator) {
 
   @Override
   public String toString() {
-    if (stringRepresentation == null) {
-      try {
-        stringRepresentation = frame.connection.localUtils().asLocatorDescription(selector);
-      } catch (PlaywrightException e) {
-        return "Locator@" + selector;
-      }
+    if (stringRepresentation != null) {
+      return stringRepresentation;
+    }
+    String description = description();
+    if (description != null) {
+      return description;
     }
-    return stringRepresentation;
+    return "Locator@" + selector;
   }
 
   @Override

playwright/src/test/java/com/microsoft/playwright/TestLocatorConvenience.java

@@ -16,7 +16,6 @@
 
 package com.microsoft.playwright;
 
-import com.microsoft.playwright.options.AriaRole;
 import org.junit.jupiter.api.Test;
 
 import static java.util.Arrays.asList;
@@ -31,10 +30,10 @@ void shouldHaveANicePreview() {
     Locator check = page.locator("#check");
     JSHandle text = inner.evaluateHandle("e => e.firstChild");
     page.evaluate("() => 1");  // Give them a chance to calculate the preview.
-    assertEquals("locator(\"#outer\")", outer.toString());
-    assertEquals("locator(\"#outer\").locator(\"#inner\")", inner.toString());
+    assertEquals("Locator@#outer", outer.toString());
+    assertEquals("Locator@#outer >> #inner", inner.toString());
     assertEquals("JSHandle@#text=Text,↵more text", text.toString());
-    assertEquals("locator(\"#check\")", check.toString());
+    assertEquals("Locator@#check", check.toString());
   }
 
   @Test
@@ -225,15 +224,15 @@ void descriptionShouldReturnLastDescriptionForMultipleCalls() {
 
   @Test
   void toStringShouldReturnFormattedLocator() {
-    Locator locator = page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Submit"));
-    assertEquals("getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName(\"Submit\"))", locator.toString());
-    assertNull(locator.description());
+    page.setContent("<div>Hello</div>");
+    Locator locator = page.locator("div");
+    assertTrue(locator.toString().startsWith("Locator@"));
   }
 
   @Test
   void toStringShouldPreferDescription() {
-    Locator locator = page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Submit")).describe("Submit button");
-    assertEquals("Submit button", locator.toString());
-    assertEquals(locator.description(), locator.toString());
+    page.setContent("<div>Hello</div>");
+    Locator locator = page.locator("div").describe("my div");
+    assertEquals("my div", locator.toString());
   }
 }

playwright/src/test/java/com/microsoft/playwright/TestPageAriaSnapshotAI.java

@@ -2,7 +2,6 @@
 
 import com.microsoft.playwright.junit.FixtureTest;
 import com.microsoft.playwright.junit.UsePlaywright;
-import com.microsoft.playwright.options.AriaRole;
 import com.microsoft.playwright.options.AriaSnapshotMode;
 import org.junit.jupiter.api.Test;
 
@@ -201,7 +200,6 @@ void shouldNormalizeRefLocatorToLocatorCode(Page page) {
 
     Locator normalized = page.getByRef("e2").normalize();
     assertEquals("getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName(\"Submit\"))", normalized.toString());
-    assertEquals(page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setName("Submit")).toString(), normalized.toString());
 
     PlaywrightException e = assertThrows(PlaywrightException.class, () -> page.getByRef("e1000").normalize());
     assertTrue(e.getMessage().contains("No element matching aria-ref=e1000"), e.getMessage());