test: port the upstream page and library tests (#2024)

Author: yury-s

.github/workflows/test.yml

@@ -12,7 +12,7 @@ env:
   PW_MAX_RETRIES: 3
 jobs:
   dev:
-    timeout-minutes: 30
+    timeout-minutes: 90
     strategy:
       fail-fast: false
       matrix:
@@ -34,11 +34,11 @@ jobs:
     - name: Install browsers
       run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps" -f playwright/pom.xml --no-transfer-progress
     - name: Run tests
-      run: mvn test --no-transfer-progress --fail-at-end -D org.slf4j.simpleLogger.showDateTime=true -D org.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss
+      run: ${{ runner.os == 'Linux' && 'xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24"' || '' }} mvn test --no-transfer-progress --fail-at-end ${{ runner.os == 'Windows' && '-D junit.parallel.factor=0.25' || '' }} -D org.slf4j.simpleLogger.showDateTime=true -D org.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss
       env:
         BROWSER: ${{ matrix.browser }}
     - name: Run tracing tests w/ sources
-      run: mvn test --no-transfer-progress --fail-at-end --projects=playwright -D test=*TestTracing* -D org.slf4j.simpleLogger.showDateTime=true -D org.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss
+      run: ${{ runner.os == 'Linux' && 'xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24"' || '' }} mvn test --no-transfer-progress --fail-at-end --projects=playwright -D test=*TestTracing* -D org.slf4j.simpleLogger.showDateTime=true -D org.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss
       env:
         BROWSER: ${{ matrix.browser }}
         PLAYWRIGHT_JAVA_SRC: src/test/java
@@ -52,7 +52,7 @@ jobs:
         java -jar target/test-spring-boot*.jar
 
   stable:
-    timeout-minutes: 30
+    timeout-minutes: 90
     strategy:
       fail-fast: false
       matrix:
@@ -81,13 +81,13 @@ jobs:
       - name: Install browsers
         run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps" -f playwright/pom.xml --no-transfer-progress
       - name: Run tests
-        run: mvn test --no-transfer-progress --fail-at-end -D org.slf4j.simpleLogger.showDateTime=true -D org.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss
+        run: ${{ runner.os == 'Linux' && 'xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24"' || '' }} mvn test --no-transfer-progress --fail-at-end ${{ runner.os == 'Windows' && '-D junit.parallel.factor=0.25' || '' }} -D org.slf4j.simpleLogger.showDateTime=true -D org.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss
         env:
           BROWSER: chromium
           BROWSER_CHANNEL: ${{ matrix.browser-channel }}
 
   Java_25:
-    timeout-minutes: 30
+    timeout-minutes: 90
     strategy:
       fail-fast: false
       matrix:
@@ -111,7 +111,7 @@ jobs:
       - name: Install browsers
         run: mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps" -f playwright/pom.xml --no-transfer-progress
       - name: Run tests
-        run: mvn test --no-transfer-progress --fail-at-end
+        run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" mvn test --no-transfer-progress --fail-at-end
         env:
           BROWSER: ${{ matrix.browser }}
       - name: Test Spring Boot Starter

driver/src/main/java/com/microsoft/playwright/impl/driver/jar/DriverJar.java

@@ -139,16 +139,19 @@ public static URI getDriverResourceURI() throws URISyntaxException {
   }
 
   void extractDriverToTempDir() throws URISyntaxException, IOException {
-    extractResourceToDir("driver/package", driverTempDir.resolve("package"));
-    if (preinstalledNodePath == null) {
-      String platformResource = "driver/" + platformDir();
-      if (DriverJar.class.getClassLoader().getResource(platformResource) == null) {
-        throw new RuntimeException("Failed to find the bundled Node.js for platform '" + platformDir()
-          + "'. Add the com.microsoft.playwright:driver-bundle dependency, or set the "
-          + PLAYWRIGHT_NODEJS_PATH + " environment variable (or the playwright.nodejs.path system "
-          + "property) to point at a preinstalled Node.js.");
+    // Concurrent extractions would share the zip file system of the jar, and the first one to finish closes it.
+    synchronized (DriverJar.class) {
+      extractResourceToDir("driver/package", driverTempDir.resolve("package"));
+      if (preinstalledNodePath == null) {
+        String platformResource = "driver/" + platformDir();
+        if (DriverJar.class.getClassLoader().getResource(platformResource) == null) {
+          throw new RuntimeException("Failed to find the bundled Node.js for platform '" + platformDir()
+            + "'. Add the com.microsoft.playwright:driver-bundle dependency, or set the "
+            + PLAYWRIGHT_NODEJS_PATH + " environment variable (or the playwright.nodejs.path system "
+            + "property) to point at a preinstalled Node.js.");
+        }
+        extractResourceToDir(platformResource, driverTempDir);
       }
-      extractResourceToDir(platformResource, driverTempDir);
     }
   }
 

playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java

@@ -743,7 +743,14 @@ private void updateWebSocketInterceptionPatterns() {
   void handleRoute(RouteImpl route) {
     Router.HandleResult handled = routes.handle(route);
     if (handled != Router.HandleResult.NoMatchingHandler) {
-      updateInterceptionPatterns();
+      try {
+        updateInterceptionPatterns();
+      } catch (PlaywrightException e) {
+        // Like the Node.js client, ignore the error when the page or the context was closed meanwhile.
+        if (!isSafeCloseError(e)) {
+          throw e;
+        }
+      }
     }
     if (handled == Router.HandleResult.NoMatchingHandler || handled == Router.HandleResult.Fallback) {
       route.resume(null, true);

playwright/src/main/java/com/microsoft/playwright/impl/FrameImpl.java

@@ -847,8 +847,8 @@ private void waitForLoadStateImpl(WaitUntilState state, WaitForLoadStateOptions
     }
 
     List<Waitable<Void>> waitables = new ArrayList<>();
+    waitables.add(page.createWaitForCloseHelper(true));
     waitables.add(new WaitForLoadStateHelper(state, logger));
-    waitables.add(page.createWaitForCloseHelper());
     waitables.add(page.createWaitableTimeout(options.timeout));
     runUntil(() -> {}, new WaitableRace<>(waitables));
   }
@@ -982,7 +982,7 @@ private Response waitForNavigationImpl(Logger logger, Runnable code, WaitForNavi
     }
     logger.log("waiting for navigation " + matcher);
     waitables.add(new WaitForNavigationHelper(matcher, options.waitUntil, logger));
-    waitables.add(page.createWaitForCloseHelper());
+    waitables.add(page.createWaitForCloseHelper(true));
     waitables.add(page.createWaitableFrameDetach(this));
     waitables.add(page.createWaitableNavigationTimeout(options.timeout));
     return runUntil(code, new WaitableRace<>(waitables));

playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java

@@ -225,7 +225,14 @@ protected void handleEvent(String event, JsonObject params) {
       route.browserContext = browserContext;
       Router.HandleResult handled = routes.handle(route);
       if (handled != Router.HandleResult.NoMatchingHandler) {
-        updateInterceptionPatterns();
+        try {
+          updateInterceptionPatterns();
+        } catch (PlaywrightException e) {
+          // Like the Node.js client, ignore the error when the page or the context was closed meanwhile.
+          if (!isSafeCloseError(e)) {
+            throw e;
+          }
+        }
       }
       if (handled == Router.HandleResult.NoMatchingHandler || handled == Router.HandleResult.Fallback) {
         browserContext.handleRoute(route);
@@ -1513,12 +1520,25 @@ <T> Waitable<T> createWaitableFrameDetach(Frame frame) {
   }
 
   <T> Waitable<T> createWaitForCloseHelper() {
-    return new WaitableRace<T>(asList(new WaitablePageClose(), new WaitablePageCrash()));
+    return createWaitForCloseHelper(false);
+  }
+
+  /** With {@code rejectIfClosed}, it is done at once when the page is already closed, like the navigation waiter of the Node.js client. */
+  <T> Waitable<T> createWaitForCloseHelper(boolean rejectIfClosed) {
+    return new WaitableRace<T>(asList(new WaitablePageClose(rejectIfClosed && isClosed), new WaitablePageCrash()));
   }
 
   private class WaitablePageClose<T> extends WaitableEvent<EventType, T> {
-    WaitablePageClose() {
+    private final boolean closedBefore;
+
+    WaitablePageClose(boolean closedBefore) {
       super(PageImpl.this.listeners, EventType.CLOSE);
+      this.closedBefore = closedBefore;
+    }
+
+    @Override
+    public boolean isDone() {
+      return closedBefore || super.isDone();
     }
 
     @Override

playwright/src/main/java/com/microsoft/playwright/impl/PlaywrightImpl.java

@@ -46,6 +46,8 @@ public static PlaywrightImpl createImpl(CreateOptions options, boolean forceNewD
       Driver.ensureDriverInstalled(env, true);
     try {
       ProcessBuilder pb = driver.createProcessBuilder();
+      // The driver is installed once per JVM with the env of the first instance, so add the env of this one.
+      pb.environment().putAll(env);
       pb.command().add("run-driver");
       pb.redirectError(ProcessBuilder.Redirect.INHERIT);
       Process p = pb.start();

playwright/src/main/java/com/microsoft/playwright/impl/StackTraceCollector.java

@@ -107,7 +107,8 @@ JsonArray currentStackTrace() {
     // Find Playwright API call
     while (index < stack.length && stack[index].getClassName().startsWith("com.microsoft.playwright.")) {
       // hack for tests
-      if (stack[index].getClassName().startsWith("com.microsoft.playwright.Test")) {
+      if (stack[index].getClassName().startsWith("com.microsoft.playwright.Test")
+          || stack[index].getClassName().startsWith("com.microsoft.playwright.tests.")) {
         break;
       }
       index++;