diff --git a/src/Reflection/EntityFieldReflection.php b/src/Reflection/EntityFieldReflection.php index 6295ce31..88bad947 100644 --- a/src/Reflection/EntityFieldReflection.php +++ b/src/Reflection/EntityFieldReflection.php @@ -71,12 +71,8 @@ public function getWritableType(): Type return new ObjectType($objectType); } - // @todo Drupal allows $entity->field_myfield = 'string'; does this break that? - if ($this->isContentEntityType()) { - // Assume the property is a field. - return new ObjectType(FieldItemListInterface::class); - } - + // ContentEntityBase::__set() passes the value to the field's + // setValue(), so $entity->field_myfield = 'string' is valid. return new MixedType(); } diff --git a/tests/src/Reflection/EntityFieldsViaMagicReflectionExtensionTest.php b/tests/src/Reflection/EntityFieldsViaMagicReflectionExtensionTest.php index 417947d0..95d288db 100644 --- a/tests/src/Reflection/EntityFieldsViaMagicReflectionExtensionTest.php +++ b/tests/src/Reflection/EntityFieldsViaMagicReflectionExtensionTest.php @@ -124,9 +124,7 @@ public function testGetPropertyEntity(): void $readableType = $propertyReflection->getReadableType(); self::assertInstanceOf(ObjectType::class, $readableType); self::assertEquals(FieldItemListInterface::class, $readableType->getClassName()); - $writeableType = $propertyReflection->getWritableType(); - self::assertInstanceOf(ObjectType::class, $writeableType); - self::assertEquals(FieldItemListInterface::class, $writeableType->getClassName()); + self::assertInstanceOf(MixedType::class, $propertyReflection->getWritableType()); $originalPropertyReflection = $this->extension->getProperty($classReflection, 'original'); $readableType = $originalPropertyReflection->getReadableType();