From 60f8b5313cfd8c7134e509aeb0cbef154d8b73c4 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Mon, 16 Nov 2026 05:58:45 -0500 Subject: [PATCH] fix(testing): ask for expected-value sources per planned test and run-e2e for API changes The plan skill now asks each planned test entry to name where its expected value comes from, citing testing:test-value, beside the entry in the template instead of after the output list. It also suggests /testing:run-e2e for an API endpoint change when no served app exists, pointing at the non-UI route. Refs: #16366 Co-Authored-By: Claude Opus 5.5 --- ...fix-16366-plan-e2e-expected-value-45498e62.md | 7 +++++++ plugins/testing/skills/plan/SKILL.md | 16 +++++++++------- 2 files changed, 16 insertions(+), 7 deletions(-) create mode 100644 .changes/testing/fix-16366-plan-e2e-expected-value-45498e62.md diff --git a/.changes/testing/fix-16366-plan-e2e-expected-value-45498e62.md b/.changes/testing/fix-16366-plan-e2e-expected-value-45498e62.md new file mode 100644 index 00000000000..f53b6adde67 --- /dev/null +++ b/.changes/testing/fix-16366-plan-e2e-expected-value-45498e62.md @@ -0,0 +1,7 @@ +--- +bump: patch +--- + +### Fixed + +- `/testing:plan` asks each planned test's entry to name its expected-value source per `testing:test-value`, where the entries are written, and suggests `/testing:run-e2e` for an API endpoint change even when no served app exists. diff --git a/plugins/testing/skills/plan/SKILL.md b/plugins/testing/skills/plan/SKILL.md index 501b0342d23..631efe36bc0 100644 --- a/plugins/testing/skills/plan/SKILL.md +++ b/plugins/testing/skills/plan/SKILL.md @@ -77,6 +77,10 @@ For each change area, produce the plan below. Omit a fuzz-target or contract-tes changed code matches its row: do not print it empty, write it as "none", or list it under "Not testing". +Every planned test's entry names where its expected value comes from and cites +`testing:test-value` (if enabled) for that choice, canned responses for a third-party client +included. + Test names follow the project's documented pattern; when undocumented, mirror the ecosystem's idiom (the PascalCase placeholders are illustrative, .NET/xUnit): @@ -84,11 +88,11 @@ idiom (the PascalCase placeholders are illustrative, .NET/xUnit): ## Test Plan for [branch/PR description] ### Unit tests -- [ ] `{Method}_Should{Behavior}_When{Condition}` — {why this matters} +- [ ] `{Method}_Should{Behavior}_When{Condition}` — {why this matters}; expected value: {source}, per `testing:test-value` - [ ] ... ### Integration tests -- [ ] `{Subject}_{Behavior}` — {what this validates} +- [ ] `{Subject}_{Behavior}` — {what this validates}; expected value: {source}, per `testing:test-value` - [ ] ... ### Architecture tests @@ -106,7 +110,7 @@ idiom (the PascalCase placeholders are illustrative, .NET/xUnit): ### Contract tests (only if a service client or consumed endpoint changed; otherwise omit this section) - [ ] {Consumer} → {provider interaction} — {requests sent, response fields relied on, where the provider verifies it} -### E2E verification (if UI/API changes) +### E2E verification (if UI/API changes; an API endpoint change counts even when no served app exists) - [ ] Navigate to {endpoint}, verify {behavior} - [ ] Submit {form}, confirm {response} - [ ] Screenshot: {page} showing {expected state} @@ -139,12 +143,10 @@ Prioritize gaps by: Present the test plan to the user. Then suggest: - `/testing:write` for identified unit/integration gaps. **For HIGH/CRITICAL coverage gaps**, the `advisor`-tool checkpoint (when available in the session) applies after the new tests land -- `/testing:run-e2e` for UI/API verification scenarios +- `/testing:run-e2e` for UI/API verification scenarios, an API endpoint change included even when + no served app exists (`/testing:run-e2e non-ui` then covers it) - `/testing:write organize` if new test projects are needed -For each planned test, name where its expected value will come from: `testing:test-value` (if -enabled). - ## Next /testing:write