From ab0a55cc5676f7b49e4151ee1541fe1f4518f1ea Mon Sep 17 00:00:00 2001 From: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com> Date: Thu, 17 Sep 2026 07:55:12 +0200 Subject: [PATCH] Avoid CodeQL false positives for Path_* types --- jsonargparse/typing.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/jsonargparse/typing.py b/jsonargparse/typing.py index f95f22a6..1be58fbb 100644 --- a/jsonargparse/typing.py +++ b/jsonargparse/typing.py @@ -245,8 +245,8 @@ def extend_base_type( Raises: ValueError: If the type has already been registered with a different name. """ - if register_key in registered_types: - registered_type = registered_types[register_key] + registered_type = None if register_key is None else registered_types.get(register_key) + if registered_type is not None: if registered_type.__name__ != name: raise ValueError(f"Same type already registered with a different name: {registered_type.__name__}.") return registered_type @@ -411,8 +411,9 @@ def path_type(mode: str, docstring: str | None = None) -> TypeAlias: key_name = "path " + "".join(sorted(mode)) register_key = (key_name, str) - if register_key in registered_types: - return registered_types[register_key] + registered_type = registered_types.get(register_key) + if registered_type is not None: + return registered_type class PathType(Path): _expression = name