From fa3ef3ff311bcd61d43e1a7d4c9b52785ed49f1a Mon Sep 17 00:00:00 2001 From: "Billy.Zheng" Date: Thu, 29 Oct 2026 11:14:18 +0800 Subject: [PATCH] Update ameba to 1.7.0 and fix ameba issues --- .ameba.yml | 25 +++++++++++++++++++++++++ .github/workflows/ci.yml | 2 ++ shard.lock | 6 +++--- shard.yml | 1 - src/start_server.cr | 2 +- tasks/generate_team_images.cr | 4 ++-- 6 files changed, 33 insertions(+), 7 deletions(-) create mode 100644 .ameba.yml diff --git a/.ameba.yml b/.ameba.yml new file mode 100644 index 00000000..627eb5c3 --- /dev/null +++ b/.ameba.yml @@ -0,0 +1,25 @@ +# This configuration file was generated by `ameba --gen-config` +# on 2026-10-24 06:33:51 UTC using Ameba version 1.7.0. +# +# The point is for the user to remove these configuration records +# one by one as the reported problems are removed from the code base. +# +# For more details on any individual rule, run +# `ameba --ignore-config --only RuleName`. + +Version: "1.7.0" + +Lint/SpecFilename: + Enabled: false + +Naming/BlockParameterName: + Enabled: false + +Style/HeredocEscape: + Enabled: false + +Style/HeredocIndent: + Enabled: false + +Style/PercentLiteralDelimiters: + Enabled: false diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d7c37e7e..d502a67e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,6 +18,8 @@ jobs: run: shards install - name: Format run: crystal tool format --check + - name: Build Ameba + run: crystal build -o bin/ameba lib/ameba/bin/ameba.cr - name: Lint run: ./bin/ameba specs: diff --git a/shard.lock b/shard.lock index 55eed0f0..120fe628 100644 --- a/shard.lock +++ b/shard.lock @@ -2,7 +2,7 @@ version: 2.0 shards: ameba: git: https://github.com/crystal-ameba/ameba.git - version: 1.5.0 + version: 1.7.0 awscr-s3: git: https://github.com/taylorfinnell/awscr-s3.git @@ -78,7 +78,7 @@ shards: lucky_router: git: https://github.com/luckyframework/lucky_router.git - version: 0.6.1 + version: 0.6.2 lucky_task: git: https://github.com/luckyframework/lucky_task.git @@ -106,7 +106,7 @@ shards: splay_tree_map: git: https://github.com/wyhaines/splay_tree_map.cr.git - version: 0.3.0 + version: 0.4.0 webdrivers: git: https://github.com/crystal-loot/webdrivers.cr.git diff --git a/shard.yml b/shard.yml index 3b954f6c..70f7d20a 100644 --- a/shard.yml +++ b/shard.yml @@ -42,4 +42,3 @@ development_dependencies: version: ~> 0.10.0 ameba: github: crystal-ameba/ameba - version: ~> 1.5.0 diff --git a/src/start_server.cr b/src/start_server.cr index 66fe6874..fdead4d8 100644 --- a/src/start_server.cr +++ b/src/start_server.cr @@ -4,7 +4,7 @@ Habitat.raise_if_missing_settings! app_server = AppServer.new -Signal::INT.trap do +Process.on_terminate do app_server.close end diff --git a/tasks/generate_team_images.cr b/tasks/generate_team_images.cr index bd76c8e8..0b9453a6 100644 --- a/tasks/generate_team_images.cr +++ b/tasks/generate_team_images.cr @@ -3,9 +3,9 @@ require "http/client" class GenerateTeamImages < LuckyTask::Task summary "generate team images" - property(members : Array(::Members::Member)) { + property(members : Array(::Members::Member)) do [::Members.creator] + ::Members.team_members - } + end def call members.each do |member|