From 7f6c99d345a07e1cd28e8dd70aa7c9bbd012969c Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Thu, 1 Oct 2026 22:04:51 -0700 Subject: [PATCH 1/3] fix(cli): save generator arguments in command metadata `lb4 --meta` collected generator arguments only `if (!gen)`, which is never true for a generator that was just created, so it wrote `"arguments": []` for every command. The committed `.yo-rc.json` still lists the arguments, so running the command or the "saves command metadata to .yo-rc.json" test rewrote the file and failed. The test snapshot of `.yo-rc.json` is updated with the `editorconfig` options that c2441cbd7 added to the file. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Raymond Feng --- packages/cli/lib/cli.js | 2 +- .../integration/cli/cli.integration.snapshots.js | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/cli/lib/cli.js b/packages/cli/lib/cli.js index 677b5e66c24d..70ec6c02cf98 100644 --- a/packages/cli/lib/cli.js +++ b/packages/cli/lib/cli.js @@ -202,7 +202,7 @@ function main(opts, log) { commandOptions[n] = {...opt, type: opt.type.name}; } const commandArgs = []; - if (!gen) { + if (gen._arguments) { for (const arg of gen._arguments) { commandArgs.push({...arg, type: arg.type.name}); } diff --git a/packages/cli/snapshots/integration/cli/cli.integration.snapshots.js b/packages/cli/snapshots/integration/cli/cli.integration.snapshots.js index 5db0a8c9c25f..5e71995efce5 100644 --- a/packages/cli/snapshots/integration/cli/cli.integration.snapshots.js +++ b/packages/cli/snapshots/integration/cli/cli.integration.snapshots.js @@ -190,6 +190,12 @@ exports[`cli saves command metadata to .yo-rc.json 1`] = ` "name": "loopbackBuild", "hide": false }, + "editorconfig": { + "type": "Boolean", + "description": "Use preconfigured EditorConfig settings", + "name": "editorconfig", + "hide": false + }, "vscode": { "type": "Boolean", "description": "Use preconfigured VSCode settings", @@ -315,6 +321,12 @@ exports[`cli saves command metadata to .yo-rc.json 1`] = ` "name": "loopbackBuild", "hide": false }, + "editorconfig": { + "type": "Boolean", + "description": "Use preconfigured EditorConfig settings", + "name": "editorconfig", + "hide": false + }, "vscode": { "type": "Boolean", "description": "Use preconfigured VSCode settings", From 302e3a9841559767157316c0be33c2903f2434fe Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Thu, 1 Oct 2026 22:15:23 -0700 Subject: [PATCH 2/3] fix(example-todo): update geopoint data in tests The US Census geocoder now returns slightly different coordinates for the test address, so `GeoLookupService` and `TodoApplication` tests fail on every platform, on master as well. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Raymond Feng --- examples/todo/src/__tests__/helpers.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/todo/src/__tests__/helpers.ts b/examples/todo/src/__tests__/helpers.ts index a9a76ccc9f53..9359e0256b61 100644 --- a/examples/todo/src/__tests__/helpers.ts +++ b/examples/todo/src/__tests__/helpers.ts @@ -48,7 +48,7 @@ export function givenTodo(todo?: Partial) { export const aLocation = { address: '1 New Orchard Road, Armonk, 10504', - geopoint: {y: 41.109728357749, x: -73.72462031805}, + geopoint: {y: 41.109725723771, x: -73.724620709372}, get geostring() { return `${this.geopoint.y},${this.geopoint.x}`; }, From 2f53d96f8ceacd1efaaa4072251cac5f9aa007d9 Mon Sep 17 00:00:00 2001 From: Raymond Feng Date: Thu, 1 Oct 2026 22:15:24 -0700 Subject: [PATCH 3/3] fix(example-webpack): allow more time to launch the browser in tests The hook that launches puppeteer and loads the page intermittently exceeds 15 seconds on the ubuntu-latest runners. It now gets 30 seconds, the same as the hook that generates the bundle. Co-Authored-By: Claude Opus 5.5 Signed-off-by: Raymond Feng --- .../src/__tests__/integration/bundle-web.integration.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/webpack/src/__tests__/integration/bundle-web.integration.ts b/examples/webpack/src/__tests__/integration/bundle-web.integration.ts index 7e1a1be70d02..08d33222fe98 100644 --- a/examples/webpack/src/__tests__/integration/bundle-web.integration.ts +++ b/examples/webpack/src/__tests__/integration/bundle-web.integration.ts @@ -39,7 +39,8 @@ skipIf<[(this: Suite) => void], void>( let browser: Browser; let html: string; before(async function (this: Mocha.Context) { - this.timeout(15000); + // Launching the browser can be slow on CI + this.timeout(30000); browser = await puppeteer.launch({ headless: true, args: ['--no-sandbox'],