Skip to content

[DOCKER] Simplify npm install for devcontainer #384

Description

@eliteprox

There are duplicate npm install and unnecessary npm run build commands at different points of the Dockerfile and post-create.sh script, both used by devcontainers

WORKDIR /workspace/comfystream/ui
RUN npm install
RUN npm run build

if [ ! -d "/workspace/comfystream/ui/node_modules" ]; then
echo -e "\e[32mInstalling npm packages for Comfystream UI...\e[0m"
cd /workspace/comfystream/ui
npm install
fi
if [ ! -d "/workspace/comfystream/nodes/web/static" ]; then
echo -e "\e[32mBuilding web assets...\e[0m"
cd /workspace/comfystream/ui
npm install
# removed it as we are already getting the built files from install.py
fi

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions