Skip to content

chore: update changelog to 6.0.43#433

Merged
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-6.0.43
May 20, 2026
Merged

chore: update changelog to 6.0.43#433
xionglinlin merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-6.0.43

Conversation

@mhduiy
Copy link
Copy Markdown
Contributor

@mhduiy mhduiy commented May 20, 2026

更新说明

自动更新 changelog 到版本 6.0.43

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 6.0.43
  • 目标分支: master

Summary by Sourcery

Chores:

  • Adjust Debian packaging metadata to reference version 6.0.43 in debian/changelog.

update changelog to 6.0.43

Log: update changelog to 6.0.43
@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 6.0.43
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 20, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian changelog to bump the package version to 6.0.43 on the master branch.

File-Level Changes

Change Details Files
Bump package version metadata in the Debian changelog to 6.0.43.
  • Add a new changelog entry for version 6.0.43 with appropriate formatting and metadata.
  • Ensure the latest 6.0.43 entry appears at the top of the changelog file as per Debian policy.
  • Update any version strings or release notes text in the new entry to reflect 6.0.43.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

你好!我是CodeGeeX,很高兴为你提供代码审查服务。

针对你提供的 git diff 内容,我进行了仔细的审查。本次提交是一个 Debian changelog 文件的更新,记录了 dde-session-ui 版本 6.0.43 的修复内容:修复了控制中心打开免责声明框时,任务栏显示额外图标标签的问题

由于本次 diff 仅包含打包和版本发布元数据的变更,不涉及具体的 C++/QML 逻辑代码,因此我将从规范符合度、变更风险、以及针对该Bug修复的延伸代码审查建议三个方面进行反馈。

1. 针对 Changelog 本身的审查

语法与规范:

  • 格式合规:该 changelog 严格遵循了 Debian changelog 的格式规范,包括版本号(加括号)、发行版(unstable)、优先级、描述、维护者信息及时间戳。
  • 时间戳格式Wed, 20 May 2026 14:20:44 +0800 格式完全符合 RFC 2822 标准,时区标注正确。

潜在风险与改进意见:

  • ⚠️ 时间旅行问题:时间戳显示为 2026年5月20日,这是一个未来的时间。虽然在某些本地开发或测试环境中生成 changelog 时可能会出现这种情况,但如果要正式发布到 Debian 仓库,Debian 的打包工具(如 dpkg-buildpackage)可能会对未来的时间戳产生警告,甚至导致排序混乱。建议:确保正式发版前,时间戳与实际提交/构建时间一致。
  • 💡 描述详细度:当前的描述 Fix: When the control center opens the disclaimer box, extra icon labels are displayed on the taskbar. 清楚地说明了问题现象。但作为深度参与开源项目的建议,如果该修复涉及特定的模块(如 DDock 或 DDialog),在描述中加入相关的模块名或 Bug 追踪号(如 Fixes: #12345)会更利于后期追溯。

2. 针对 Bug 本身的延伸代码审查建议

虽然 diff 中没有展示具体的代码实现,但基于该 Bug 的描述(控制中心打开免责声明框时,任务栏显示额外图标标签),我可以推断出导致该问题的常见原因,并对后续代码逻辑提出以下审查建议:

逻辑与质量

在 DDE(Deepin Desktop Environment)的架构中,控制中心打开弹窗(如免责声明 Dialog)时,通常是因为该弹窗被声明为了一个独立的窗口,导致任务栏将其识别为一个新应用并显示了图标和标签。

改进建议:

  • 窗口属性设置:请检查免责声明弹窗(可能是 DDialogQWidget/QWindow)是否正确设置了跳过任务栏的属性。在 Qt 中,应确保设置了:
    // 确保弹窗不显示在任务栏中
    window->setFlags(window->flags() | Qt::Tool | Qt::FramelessWindowHint);
    // 或者使用 DDE 的扩展属性
    DWindowManagerHelper::instance()->setWindowAttribute(window, DWindowManagerHelper::DockSkip);
  • 父子窗口关系:确保弹窗有正确的父窗口。如果没有指定父窗口,窗口管理器会将其视为顶级应用窗口,从而在任务栏分配图标。

性能

  • 避免频繁的属性动态切换:如果在代码中是通过监听显示/隐藏事件来动态修改窗口的 DockSkip 属性,这会引发窗口管理器的重绘和任务栏的刷新,产生性能开销。建议:在弹窗实例化初始化阶段一次性设置好窗口属性,而不是在 showEvent 中动态调整。

安全

  • 免责声明内容加载:虽然此 Bug 是 UI 展示问题,但涉及“免责声明框”通常需要加载富文本或外部文件/URL。
    • 如果使用 QLabel 显示文本,请确保没有直接使用 setTextFormat(Qt::RichText) 去渲染不受信任的 HTML,以防止潜在的 XSS 或富文本解析漏洞。
    • 如果内容来自本地文件,请校验文件的完整性;如果来自网络,必须使用 HTTPS 并对内容进行严格的转义处理。

总结

本次 changelog 的变更格式规范、描述清晰,可以合入。唯一需要关注的是**时间戳异常(2026年)**的问题,请在正式打包发布前确认是否需要修正。

如果后续有针对该 Bug 的 C++ 或 QML 代码 diff,欢迎提供,我将为你进行更深层次的语法、逻辑、性能和安全性审查!

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, xionglinlin

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin xionglinlin merged commit 0ded68a into linuxdeepin:master May 20, 2026
18 of 20 checks passed
@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 20, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.43
  • Tag SHA: 27cf30b2692b5978d72d4eb710766c09f30a3fab
  • Commit SHA: f528fb76a5af97526f4ef30172a334e7bd98881b
  • Tag Message:
    Release dde-session-ui 6.0.43
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants