Skip to content

Commit 98a3862

Browse files
committed
Fix hardcoded labels
1 parent 64ba0ad commit 98a3862

2 files changed

Lines changed: 3 additions & 11 deletions

File tree

‎test/integration/models/image/test_image.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,10 @@ def image_upload_url(test_linode_client):
4343

4444
region = get_image_upload_regions(test_linode_client)[0]
4545

46-
test_linode_client.image_create_upload(
46+
image, _ = test_linode_client.image_create_upload(
4747
label, region.id, "integration test image upload"
4848
)
4949

50-
image = test_linode_client.images()[0]
51-
5250
yield image
5351

5452
image.delete()

‎test/integration/models/sharegroups/test_sharegroups.py‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import pytest
66

7-
from linode_api4.errors import ApiError
87
from linode_api4.objects import (
98
Image,
109
ImageShareGroup,
@@ -55,18 +54,13 @@ def sample_linode(test_linode_client, e2e_test_firewall):
5554
def create_image_id(test_linode_client, sample_linode):
5655
create_image = test_linode_client.images.create(
5756
sample_linode.disks[0],
58-
label="linode-api4python-test-image-sharing-image",
57+
label=get_test_label(8) + "_sharing-image",
5958
)
6059
wait_for_image_status(test_linode_client, create_image.id, "available")
6160

6261
yield create_image.id
6362

64-
try:
65-
create_image.delete()
66-
except ApiError as e:
67-
# The image may already have been removed so we ignore [404] Not found
68-
if e.status != 404:
69-
raise
63+
create_image.delete()
7064

7165

7266
@pytest.fixture(scope="function")

0 commit comments

Comments
 (0)