From 25a89f5ec6bc669093c14aa954a2c0e09d61588c Mon Sep 17 00:00:00 2001 From: Aaron Ware Date: Mon, 14 Sep 2026 17:31:45 -0400 Subject: [PATCH 1/2] fix(LINCHPIN-5617): Drop the deprecated CallTimePassByReference sniff from Linchpin-Minimum MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PHPCS deprecated Generic.Functions.CallTimePassByReference in 3.12.1, and referencing a deprecated sniff makes it print a banner to stdout ahead of the report. That leaves the JSON report unparseable, so Linchpin\Composer\Actions::phpcs_report() decodes null and check-branch-cs exits 1 with "PHPCS produced no parseable report." on every run, whether or not the diff has violations — breaking the pre-commit hook and the CI step for every repo on Linchpin-Minimum. The full Linchpin ruleset has excluded this sniff for a while; Linchpin-Minimum never got the same treatment. Nothing is lost by dropping it: call-time pass-by-reference has been a fatal error since PHP 5.4 and this package requires PHP 8.0 or later, so there is no replacement sniff to reference. Co-Authored-By: Claude Opus 5 (1M context) --- Linchpin-Minimum/ruleset.xml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Linchpin-Minimum/ruleset.xml b/Linchpin-Minimum/ruleset.xml index dce0f37..2b8f200 100644 --- a/Linchpin-Minimum/ruleset.xml +++ b/Linchpin-Minimum/ruleset.xml @@ -148,8 +148,13 @@ - - + From 2348df88e1c2d834f87d68869f65e8931010c706 Mon Sep 17 00:00:00 2001 From: Aaron Ware Date: Mon, 14 Sep 2026 22:42:28 -0400 Subject: [PATCH 2/2] Apply suggestion from @aaronware --- Linchpin-Minimum/ruleset.xml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/Linchpin-Minimum/ruleset.xml b/Linchpin-Minimum/ruleset.xml index 2b8f200..9b614c2 100644 --- a/Linchpin-Minimum/ruleset.xml +++ b/Linchpin-Minimum/ruleset.xml @@ -148,13 +148,6 @@ -