diff --git a/java/lance-namespace-glue/src/main/java/org/lance/namespace/glue/GlueNamespace.java b/java/lance-namespace-glue/src/main/java/org/lance/namespace/glue/GlueNamespace.java index 66a7cc8..e166b6a 100644 --- a/java/lance-namespace-glue/src/main/java/org/lance/namespace/glue/GlueNamespace.java +++ b/java/lance-namespace-glue/src/main/java/org/lance/namespace/glue/GlueNamespace.java @@ -39,6 +39,7 @@ import org.lance.namespace.model.ListTablesRequest; import org.lance.namespace.model.ListTablesResponse; import org.lance.namespace.model.TableExistsRequest; +import org.lance.namespace.model.TableExistsResponse; import org.lance.namespace.util.LanceTableUtil; import com.google.common.annotations.VisibleForTesting; @@ -269,13 +270,14 @@ public DescribeTableResponse describeTable(DescribeTableRequest request) { } @Override - public void tableExists(TableExistsRequest request) { + public TableExistsResponse tableExists(TableExistsRequest request) { validateTableId(request.getId()); String namespaceName = request.getId().get(0); String tableName = request.getId().get(1); Table table = getGlueTable(namespaceName, tableName); ensureLanceTable(table); + return new TableExistsResponse(); } @Override diff --git a/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java b/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java index 19dea63..da86c65 100644 --- a/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java +++ b/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java @@ -41,7 +41,9 @@ import org.lance.namespace.model.ListTablesRequest; import org.lance.namespace.model.ListTablesResponse; import org.lance.namespace.model.NamespaceExistsRequest; +import org.lance.namespace.model.NamespaceExistsResponse; import org.lance.namespace.model.TableExistsRequest; +import org.lance.namespace.model.TableExistsResponse; import org.lance.namespace.util.LanceTableUtil; import com.google.common.collect.Lists; @@ -147,7 +149,7 @@ public CreateNamespaceResponse createNamespace(CreateNamespaceRequest request) { } @Override - public void namespaceExists(NamespaceExistsRequest request) { + public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) { ObjectIdentifier id = ObjectIdentifier.of(request.getId()); ValidationUtil.checkArgument( @@ -162,6 +164,8 @@ public void namespaceExists(NamespaceExistsRequest request) { HiveMetaStoreError.getType(), id.stringStyleId()); } + + return new NamespaceExistsResponse(); } @Override @@ -247,7 +251,7 @@ public ListTablesResponse listTables(ListTablesRequest request) { } @Override - public void tableExists(TableExistsRequest request) { + public TableExistsResponse tableExists(TableExistsRequest request) { ObjectIdentifier tableId = ObjectIdentifier.of(request.getId()); ValidationUtil.checkArgument( @@ -266,6 +270,7 @@ public void tableExists(TableExistsRequest request) { } Hive2Util.validateLanceTable(hmsTable.get()); + return new TableExistsResponse(); } @Override diff --git a/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java b/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java index a22d9bf..d1c52c9 100644 --- a/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java +++ b/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java @@ -42,7 +42,9 @@ import org.lance.namespace.model.ListTablesRequest; import org.lance.namespace.model.ListTablesResponse; import org.lance.namespace.model.NamespaceExistsRequest; +import org.lance.namespace.model.NamespaceExistsResponse; import org.lance.namespace.model.TableExistsRequest; +import org.lance.namespace.model.TableExistsResponse; import org.lance.namespace.util.LanceTableUtil; import com.google.common.collect.Lists; @@ -196,7 +198,7 @@ public DescribeNamespaceResponse describeNamespace(DescribeNamespaceRequest requ } @Override - public void namespaceExists(NamespaceExistsRequest request) { + public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) { ObjectIdentifier id = ObjectIdentifier.of(request.getId()); ValidationUtil.checkArgument( @@ -220,6 +222,8 @@ public void namespaceExists(NamespaceExistsRequest request) { String.format("Namespace does not exist: %s", id.stringStyleId())); } } + + return new NamespaceExistsResponse(); } @Override @@ -243,7 +247,7 @@ public DropNamespaceResponse dropNamespace(DropNamespaceRequest request) { } @Override - public void tableExists(TableExistsRequest request) { + public TableExistsResponse tableExists(TableExistsRequest request) { ObjectIdentifier tableId = ObjectIdentifier.of(request.getId()); ValidationUtil.checkArgument( @@ -261,6 +265,7 @@ public void tableExists(TableExistsRequest request) { } Hive3Util.validateLanceTable(hmsTable.get()); + return new TableExistsResponse(); } @Override diff --git a/java/lance-namespace-iceberg/src/main/java/org/lance/namespace/iceberg/IcebergNamespace.java b/java/lance-namespace-iceberg/src/main/java/org/lance/namespace/iceberg/IcebergNamespace.java index 33ade28..08a35f5 100644 --- a/java/lance-namespace-iceberg/src/main/java/org/lance/namespace/iceberg/IcebergNamespace.java +++ b/java/lance-namespace-iceberg/src/main/java/org/lance/namespace/iceberg/IcebergNamespace.java @@ -37,7 +37,9 @@ import org.lance.namespace.model.ListTablesRequest; import org.lance.namespace.model.ListTablesResponse; import org.lance.namespace.model.NamespaceExistsRequest; +import org.lance.namespace.model.NamespaceExistsResponse; import org.lance.namespace.model.TableExistsRequest; +import org.lance.namespace.model.TableExistsResponse; import org.lance.namespace.rest.RestClient; import org.lance.namespace.rest.RestClientException; import org.lance.namespace.util.LanceTableUtil; @@ -265,8 +267,9 @@ public DescribeNamespaceResponse describeNamespace(DescribeNamespaceRequest requ } @Override - public void namespaceExists(NamespaceExistsRequest request) { + public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) { describeNamespace(new DescribeNamespaceRequest().id(request.getId())); + return new NamespaceExistsResponse(); } @Override @@ -457,8 +460,9 @@ public DescribeTableResponse describeTable(DescribeTableRequest request) { } @Override - public void tableExists(TableExistsRequest request) { + public TableExistsResponse tableExists(TableExistsRequest request) { describeTable(new DescribeTableRequest().id(request.getId())); + return new TableExistsResponse(); } @Override diff --git a/java/lance-namespace-polaris/src/main/java/org/lance/namespace/polaris/PolarisNamespace.java b/java/lance-namespace-polaris/src/main/java/org/lance/namespace/polaris/PolarisNamespace.java index b359145..e86ee91 100644 --- a/java/lance-namespace-polaris/src/main/java/org/lance/namespace/polaris/PolarisNamespace.java +++ b/java/lance-namespace-polaris/src/main/java/org/lance/namespace/polaris/PolarisNamespace.java @@ -37,7 +37,9 @@ import org.lance.namespace.model.ListTablesRequest; import org.lance.namespace.model.ListTablesResponse; import org.lance.namespace.model.NamespaceExistsRequest; +import org.lance.namespace.model.NamespaceExistsResponse; import org.lance.namespace.model.TableExistsRequest; +import org.lance.namespace.model.TableExistsResponse; import org.lance.namespace.rest.RestClient; import org.lance.namespace.rest.RestClientException; import org.lance.namespace.util.LanceTableUtil; @@ -223,7 +225,7 @@ public DropNamespaceResponse dropNamespace(DropNamespaceRequest request) { } @Override - public void namespaceExists(NamespaceExistsRequest request) { + public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) { ObjectIdentifier namespaceId = ObjectIdentifier.of(request.getId()); ValidationUtil.checkArgument( namespaceId.levels() >= 2, "Namespace must have at least catalog and namespace levels"); @@ -236,6 +238,7 @@ public void namespaceExists(NamespaceExistsRequest request) { restClient.get( "/v1/" + catalog + "/namespaces/" + namespacePath, PolarisModels.NamespaceResponse.class); + return new NamespaceExistsResponse(); } catch (RestClientException e) { if (e.isNotFound()) { throw new NamespaceNotFoundException("Namespace not found: " + namespaceId.stringStyleId()); @@ -245,7 +248,7 @@ public void namespaceExists(NamespaceExistsRequest request) { } @Override - public void tableExists(TableExistsRequest request) { + public TableExistsResponse tableExists(TableExistsRequest request) { ObjectIdentifier tableId = ObjectIdentifier.of(request.getId()); ValidationUtil.checkArgument( tableId.levels() >= 3, "Table identifier must have catalog, namespace, and table name"); @@ -265,6 +268,7 @@ public void tableExists(TableExistsRequest request) { + "/generic-tables/" + tableName, PolarisModels.LoadGenericTableResponse.class); + return new TableExistsResponse(); } catch (RestClientException e) { if (e.isNotFound()) { throw new TableNotFoundException("Table not found: " + tableId.stringStyleId()); diff --git a/java/lance-namespace-unity/src/main/java/org/lance/namespace/unity/UnityNamespace.java b/java/lance-namespace-unity/src/main/java/org/lance/namespace/unity/UnityNamespace.java index 1dd9cb3..92511e2 100644 --- a/java/lance-namespace-unity/src/main/java/org/lance/namespace/unity/UnityNamespace.java +++ b/java/lance-namespace-unity/src/main/java/org/lance/namespace/unity/UnityNamespace.java @@ -37,7 +37,9 @@ import org.lance.namespace.model.ListTablesRequest; import org.lance.namespace.model.ListTablesResponse; import org.lance.namespace.model.NamespaceExistsRequest; +import org.lance.namespace.model.NamespaceExistsResponse; import org.lance.namespace.model.TableExistsRequest; +import org.lance.namespace.model.TableExistsResponse; import org.lance.namespace.rest.RestClient; import org.lance.namespace.rest.RestClientException; import org.lance.namespace.util.LanceTableUtil; @@ -223,8 +225,9 @@ public DescribeNamespaceResponse describeNamespace(DescribeNamespaceRequest requ } @Override - public void namespaceExists(NamespaceExistsRequest request) { + public NamespaceExistsResponse namespaceExists(NamespaceExistsRequest request) { describeNamespace(new DescribeNamespaceRequest().id(request.getId())); + return new NamespaceExistsResponse(); } @Override @@ -419,8 +422,9 @@ public DescribeTableResponse describeTable(DescribeTableRequest request) { } @Override - public void tableExists(TableExistsRequest request) { + public TableExistsResponse tableExists(TableExistsRequest request) { describeTable(new DescribeTableRequest().id(request.getId())); + return new TableExistsResponse(); } @Override diff --git a/java/pom.xml b/java/pom.xml index 489769d..17d30d5 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -58,7 +58,7 @@ UTF-8 7.0.0 - 0.7.7 + 0.13.0 18.3.0 4.1.118.Final 5.8.2