From 1cf51236bea44c66d1a8e9ca2f3b7f67c6e455d1 Mon Sep 17 00:00:00 2001 From: "zhanghaobo@kanzhun.com" Date: Fri, 10 Jul 2026 16:56:56 +0800 Subject: [PATCH 1/3] feat: expose Hive client pools --- .../main/java/org/lance/namespace/hive2/Hive2Namespace.java | 5 +++++ .../java/org/lance/namespace/hive2/TestHive2Namespace.java | 6 ++++++ .../main/java/org/lance/namespace/hive3/Hive3Namespace.java | 5 +++++ .../java/org/lance/namespace/hive3/TestHive3Namespace.java | 6 ++++++ 4 files changed, 22 insertions(+) diff --git a/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java b/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java index 19dea63..ade0a22 100644 --- a/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java +++ b/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java @@ -91,6 +91,11 @@ public void setHadoopConf(Configuration conf) { this.hadoopConf = conf; } + /** Returns the Hive Metastore client pool used by this namespace. */ + public Hive2ClientPool getClientPool() { + return clientPool; + } + @Override public void initialize(Map configProperties, BufferAllocator allocator) { this.allocator = allocator; diff --git a/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java b/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java index 991d947..66cd9a1 100644 --- a/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java +++ b/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java @@ -55,6 +55,7 @@ import static java.nio.file.attribute.PosixFilePermissions.fromString; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertSame; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -103,6 +104,11 @@ public void cleanup() throws Exception { metastore.reset(); } + @Test + public void testGetClientPool() { + assertSame(metastore.clientPool(), ((Hive2Namespace) namespace).getClientPool()); + } + @Test public void testDescribeNonExistentTable() { // Setup: Create database diff --git a/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java b/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java index a22d9bf..5ba3d84 100644 --- a/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java +++ b/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java @@ -82,6 +82,11 @@ public void setHadoopConf(Configuration conf) { this.hadoopConf = conf; } + /** Returns the Hive Metastore client pool used by this namespace. */ + public Hive3ClientPool getClientPool() { + return clientPool; + } + @Override public void initialize(Map configProperties, BufferAllocator allocator) { this.allocator = allocator; diff --git a/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java b/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java index 47a36e0..b7c1293 100644 --- a/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java +++ b/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java @@ -56,6 +56,7 @@ import static java.nio.file.attribute.PosixFilePermissions.fromString; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertSame; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -128,6 +129,11 @@ public void cleanup() throws Exception { namespace.createNamespace(nsRequest); } + @Test + public void testGetClientPool() { + assertSame(metastore.clientPool(), ((Hive3Namespace) namespace).getClientPool()); + } + @Test public void testDescribeNonExistentTable() { // Test: Describe non-existent table From 25d85b7e2e533b180df28132c6875b699af3d1ec Mon Sep 17 00:00:00 2001 From: "zhanghaobo@kanzhun.com" Date: Fri, 10 Jul 2026 17:10:03 +0800 Subject: [PATCH 2/3] remove useless comments --- .../src/main/java/org/lance/namespace/hive2/Hive2Namespace.java | 1 - .../src/main/java/org/lance/namespace/hive3/Hive3Namespace.java | 1 - 2 files changed, 2 deletions(-) diff --git a/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java b/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java index ade0a22..07047f3 100644 --- a/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java +++ b/java/lance-namespace-hive2/src/main/java/org/lance/namespace/hive2/Hive2Namespace.java @@ -91,7 +91,6 @@ public void setHadoopConf(Configuration conf) { this.hadoopConf = conf; } - /** Returns the Hive Metastore client pool used by this namespace. */ public Hive2ClientPool getClientPool() { return clientPool; } diff --git a/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java b/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java index 5ba3d84..ed12ab2 100644 --- a/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java +++ b/java/lance-namespace-hive3/src/main/java/org/lance/namespace/hive3/Hive3Namespace.java @@ -82,7 +82,6 @@ public void setHadoopConf(Configuration conf) { this.hadoopConf = conf; } - /** Returns the Hive Metastore client pool used by this namespace. */ public Hive3ClientPool getClientPool() { return clientPool; } From d441dafb97b3fe9b968dc858f1e0e397ea6a3708 Mon Sep 17 00:00:00 2001 From: "zhanghaobo@kanzhun.com" Date: Fri, 10 Jul 2026 17:14:33 +0800 Subject: [PATCH 3/3] test: verify Hive client pool getters --- .../java/org/lance/namespace/hive2/TestHive2Namespace.java | 4 ++-- .../java/org/lance/namespace/hive3/TestHive3Namespace.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java b/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java index 66cd9a1..91477d5 100644 --- a/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java +++ b/java/lance-namespace-hive2/src/test/java/org/lance/namespace/hive2/TestHive2Namespace.java @@ -55,7 +55,7 @@ import static java.nio.file.attribute.PosixFilePermissions.fromString; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertSame; +import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -106,7 +106,7 @@ public void cleanup() throws Exception { @Test public void testGetClientPool() { - assertSame(metastore.clientPool(), ((Hive2Namespace) namespace).getClientPool()); + assertNotNull(((Hive2Namespace) namespace).getClientPool()); } @Test diff --git a/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java b/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java index b7c1293..e2fb051 100644 --- a/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java +++ b/java/lance-namespace-hive3/src/test/java/org/lance/namespace/hive3/TestHive3Namespace.java @@ -56,7 +56,7 @@ import static java.nio.file.attribute.PosixFilePermissions.fromString; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertSame; +import static org.junit.jupiter.api.Assertions.assertNotNull; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -131,7 +131,7 @@ public void cleanup() throws Exception { @Test public void testGetClientPool() { - assertSame(metastore.clientPool(), ((Hive3Namespace) namespace).getClientPool()); + assertNotNull(((Hive3Namespace) namespace).getClientPool()); } @Test