diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml index cf83a77..fae651c 100644 --- a/.github/workflows/style.yml +++ b/.github/workflows/style.yml @@ -48,6 +48,13 @@ jobs: sudo apt install -y clang libclang-dev protobuf-compiler - name: Clippy run: cargo clippy --workspace --all-targets -- -D warnings + # `--workspace` unions every member's features, so `lance-context` is + # always built with `remote` enabled by lance-context-server/-client. + # The release job checks the crate on its own (`default = []`), a + # combination the line above never exercises. Check it explicitly so + # cfg-gated breakage is caught here instead of at release time. + - name: Clippy (lance-context, default features) + run: cargo clippy --manifest-path crates/lance-context/Cargo.toml --all-targets -- -D warnings typos: name: Spell Check diff --git a/crates/lance-context/src/unified_generic.rs b/crates/lance-context/src/unified_generic.rs index 86119d8..7a090a7 100644 --- a/crates/lance-context/src/unified_generic.rs +++ b/crates/lance-context/src/unified_generic.rs @@ -1,12 +1,13 @@ use std::collections::HashMap; use lance_context_api::{ - AddRowsResponse, ContextError, ContextResult, CreateGenericStoreRequest, GenericStoreApi, - SchemaSpec, + AddRowsResponse, ContextError, ContextResult, GenericStoreApi, SchemaSpec, }; use lance_context_core::{GenericStore as LocalStore, GenericStoreOptions}; use serde_json::{Map, Value}; +#[cfg(feature = "remote")] +use lance_context_api::CreateGenericStoreRequest; #[cfg(feature = "remote")] use lance_context_client::RemoteGenericStore;