From 087c55e8435776037d4683084622578776e39829 Mon Sep 17 00:00:00 2001 From: Beinan Date: Wed, 29 Jul 2026 07:21:25 +0000 Subject: [PATCH] fix: gate CreateGenericStoreRequest import behind remote feature `CreateGenericStoreRequest` is only referenced by `connect_or_create`, which is `#[cfg(feature = "remote")]`. Importing it unconditionally made it an unused import in default-feature builds, failing the release workflow's `cargo check` under `-D warnings`. Move the import into the existing `#[cfg(feature = "remote")]` group so it is present exactly where it is used. Co-Authored-By: Claude --- crates/lance-context/src/unified_generic.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/lance-context/src/unified_generic.rs b/crates/lance-context/src/unified_generic.rs index 86119d8..7a090a7 100644 --- a/crates/lance-context/src/unified_generic.rs +++ b/crates/lance-context/src/unified_generic.rs @@ -1,12 +1,13 @@ use std::collections::HashMap; use lance_context_api::{ - AddRowsResponse, ContextError, ContextResult, CreateGenericStoreRequest, GenericStoreApi, - SchemaSpec, + AddRowsResponse, ContextError, ContextResult, GenericStoreApi, SchemaSpec, }; use lance_context_core::{GenericStore as LocalStore, GenericStoreOptions}; use serde_json::{Map, Value}; +#[cfg(feature = "remote")] +use lance_context_api::CreateGenericStoreRequest; #[cfg(feature = "remote")] use lance_context_client::RemoteGenericStore;