Skip to content

Commit c876edf

Browse files
author
rzisholz
committed
CP-25864: fix README's remaining per-tenant wording and shared literal
"Per-tenant Conjur onboarding" and the worked example's literal --set config.cyberark.serviceId=disco-agent contradicted the per-cluster-unique framing this PR already established in the generated values comment. Retitle the section, correct the onboarding sentence, and replace the shared literal with a placeholder variable.
1 parent 62a26ad commit c876edf

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

‎deploy/charts/disco-agent/README.md‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,15 @@ agent expects (`/var/run/secrets/tokens/jwt`) — this path isn't configurable,
9797
so there's one fewer way to misconfigure it. No manual volume configuration
9898
is required.
9999

100-
### Per-tenant Conjur onboarding
100+
### Per-cluster Conjur onboarding
101101

102-
Before deploying the agent, the target tenant must be onboarded in Conjur
102+
Before deploying the agent, the target cluster must be onboarded in Conjur
103103
Cloud: an `authn-jwt` authenticator scoped to the cluster's OIDC issuer and
104104
JWKS, a registered workload for the agent's ServiceAccount, and the grants that
105-
let that workload authenticate and upload. Onboarding is performed through the
106-
CyberArk web console — see the product documentation for the current
107-
walkthrough.
105+
let that workload authenticate and upload. Each cluster gets its own
106+
authenticator and service ID — the value is not shared across a tenant's
107+
clusters. Onboarding is performed through the CyberArk web console — see the
108+
product documentation for the current walkthrough.
108109

109110
Onboarding needs only the tenant administrator's own Conjur Cloud credentials.
110111
The agent itself holds no Conjur identity beyond its projected ServiceAccount
@@ -117,12 +118,13 @@ value for `config.cyberark.serviceId` below.
117118
### Deploy the agent
118119

119120
```sh
121+
# $SERVICE_ID is this cluster's own authn-jwt service ID from onboarding above — do not reuse it across clusters.
120122
helm upgrade agent "oci://${OCI_BASE}/charts/disco-agent" \
121123
--install \
122124
--create-namespace \
123125
--namespace "$NAMESPACE" \
124126
--set fullnameOverride=disco-agent \
125-
--set config.cyberark.serviceId=disco-agent \
127+
--set config.cyberark.serviceId="$SERVICE_ID" \
126128
--set acceptTerms=true
127129
```
128130

0 commit comments

Comments
 (0)