Skip to content

make unit-test leaves behind containers #1509

@BenjaminPelletier

Description

@BenjaminPelletier

Describe the bug
After make unit-test completes, it leaves behind containers that interfere with a local DSS deployment.

To reproduce

  • Start with no containers
  • make unit-test from repo root
  • docker container ls -> 6 containers

Difference from expected behavior
When unit testing is complete, it should clean up after itself or else print a message telling the user how to clean up.

Possible solution
If these containers are cheap to bring up, then make unit-test should probably just destroy the containers after running the necessary tests.

If these containers are relatively expensive to bring up and/or a developer will likely run unit tests many times with one set of containers, perhaps add another make command to clean up and print that information as the last thing make unit-test does.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal prioritybugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions