Skip to content

Refactoring with checkmate and rlang#548

Open
PavanLomati wants to merge 3 commits into
humanpred:mainfrom
PavanLomati:checkmate-rlang-refactor
Open

Refactoring with checkmate and rlang#548
PavanLomati wants to merge 3 commits into
humanpred:mainfrom
PavanLomati:checkmate-rlang-refactor

Conversation

@PavanLomati

Copy link
Copy Markdown
Contributor

No description provided.

@PavanLomati PavanLomati requested a review from billdenney May 27, 2026 04:18
@billdenney

Copy link
Copy Markdown
Member

This looks like it will make all of the code more consistent. Thank you!. Please merge in the current origin/main branch and resolve the conflicts.

Also, for many of the checkmate calls, you've added .var.name = "name" or similar where name is the parameter name used. Please omit those as they are not necessary since they are the default that checkmate will provide.

…ng-refactor

# Conflicts:
#	R/001-add.interval.col.R
#	R/PKNCA.options.R
#	R/assertions.R
#	R/auc.R
#	R/aucint.R
#	R/class-PKNCAdata.R
#	R/class-PKNCAdose.R
#	R/class-general.R
#	R/class-summary_PKNCAresults.R
#	R/exclude.R
#	R/interpolate.conc.R
#	R/pk.calc.all.R
#	R/pk.calc.c0.R
#	R/superposition.R
#	R/tss.R
#	R/tss.monoexponential.R
#	R/tss.stepwise.linear.R
#	tests/testthat/test-PKNCA.options.R
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants