From 1d5516f288629c97f29ae684da7a06d288be3114 Mon Sep 17 00:00:00 2001 From: Torben Dannhauer Date: Mon, 18 May 2026 23:05:51 +0200 Subject: [PATCH] Refactor validation logic for form variables --- lib/Horde/Form.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/Horde/Form.php b/lib/Horde/Form.php index 58c1441..04baad9 100644 --- a/lib/Horde/Form.php +++ b/lib/Horde/Form.php @@ -824,7 +824,10 @@ public function validate($vars = null, $canAutoFill = false) foreach ($this->getVariables() as $var) { $this->_autofilled = $var->_autofilled && $this->_autofilled; - if (!$var->validate($vars, $message)) { + $valid = $var instanceof Horde_Form_Variable + ? $var->validate($vars, $message) + : $var->validate($vars); + if (!$valid) { $this->_errors[$var->getVarName()] = $var->getMessage(); } } @@ -834,7 +837,10 @@ public function validate($vars = null, $canAutoFill = false) } foreach ($this->_hiddenVariables as $var) { - if (!$var->validate($vars, $message)) { + $valid = $var instanceof Horde_Form_Variable + ? $var->validate($vars, $message) + : $var->validate($vars); + if (!$valid) { $this->_errors[$var->getVarName()] = $var->getMessage(); } }