Skip to content

SRE-720: Simplify PR-title preflight — drop two-step skip logic#66

Merged
TimDiekmann merged 2 commits into
mainfrom
t/sre-720-simplify-pr-title-preflight
May 22, 2026
Merged

SRE-720: Simplify PR-title preflight — drop two-step skip logic#66
TimDiekmann merged 2 commits into
mainfrom
t/sre-720-simplify-pr-title-preflight

Conversation

@TimDiekmann
Copy link
Copy Markdown
Member

Summary

  • Folds the bot-author check into the job-level if::
    if: (github.event_name == 'pull_request' || github.event_name == 'pull_request_target') && github.event.pull_request.user.type != 'Bot'
  • Removes the separate Determine whether to skip step and the unused ignored-actors workflow input.

Same behavior for both human and bot authors; just less moving parts. The ignored-actors input was added speculatively in SRE-715 and no consumer uses it — trivial to re-add as another && clause if a future case needs to exempt a human account.

Related: SRE-720, follow-up to SRE-715.

Test plan

  • Self-PR (this PR touches the workflow file) triggers the workflow and passes (SRE-720 in title).
  • After merge, a human-authored PR without an ID still fails the check.
  • After merge, a hash-worker[bot] / dependabot[bot] PR still skips correctly.

Folds the bot-author check into the job-level `if:` and removes the
separate "Determine whether to skip" step plus the unused `ignored-actors`
workflow input. One step (validate), one condition, same behavior for
human + bot authors.

If a future case needs to exempt a human account, it's a trivial `&&` on
the `if:` to add it back.
@TimDiekmann TimDiekmann requested a review from a team May 22, 2026 18:07
@cursor
Copy link
Copy Markdown

cursor Bot commented May 22, 2026

PR Summary

Low Risk
Low risk GitHub Actions workflow change that only adjusts when the PR-title check runs; no production code paths are affected.

Overview
Simplifies the PR-title preflight workflow by removing the separate “determine whether to skip” step and the unused workflow_call input for ignored-actors.

The bot exemption is now enforced directly in the job-level if: condition (pull_request.user.type != 'Bot'), keeping the Linear issue ID validation logic unchanged for human-authored PRs.

Reviewed by Cursor Bugbot for commit c1d7116. Bugbot is set up for automated code reviews on this repo. Configure here.

@TimDiekmann TimDiekmann enabled auto-merge May 22, 2026 18:08
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 22, 2026

🤖 Augment PR Summary

Summary: This PR simplifies the PR-title preflight workflow by removing the two-step skip mechanism.

Changes:

  • Moves the bot-author exemption into the job-level if: condition.
  • Removes the dedicated “Determine whether to skip the check” step and its output gating.
  • Drops the unused workflow_call input ignored-actors and related logic.

Technical Notes: Behavior remains the same for bot-authored PRs (workflow job is skipped), while human-authored PRs continue to be validated for a Linear issue ID in the title prefix.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread .github/workflows/preflight-pr-title.yml
@TimDiekmann TimDiekmann added this pull request to the merge queue May 22, 2026
Merged via the queue into main with commit 8e6efeb May 22, 2026
9 checks passed
@TimDiekmann TimDiekmann deleted the t/sre-720-simplify-pr-title-preflight branch May 22, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants