From 0acf1bbfa0a9ab451ab9d6d0d2aa8ae76f71f881 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Wed, 24 Jun 2026 08:06:59 -0700 Subject: [PATCH 1/3] Update bazel module setup Downstream in the bazel central registry there is some naive parsing that doesn't work well with constants like this. We can inline this value instead. I left around CPU_FEATURES_VERSION to make sure the sed was unambiguous. This also removes the `repo_name` which was unused --- MODULE.bazel | 12 +----------- scripts/make_release.sh | 2 +- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index 17f69f1c..5b632ef2 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -1,16 +1,6 @@ -############################################################################### -# Bazel now uses Bzlmod by default to manage external dependencies. -# Please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. -# -# For more details, please check https://github.com/bazelbuild/bazel/issues/18958 -############################################################################### - -CPU_FEATURES_VERSION = "0.11.0" - module( name = "cpu_features", - repo_name = "com_google_cpufeatures", - version = CPU_FEATURES_VERSION, + version = "0.11.0", # CPU_FEATURES_VERSION ) bazel_dep(name = "bazel_skylib", version = "1.9.0") diff --git a/scripts/make_release.sh b/scripts/make_release.sh index d15adfcd..59a42242 100755 --- a/scripts/make_release.sh +++ b/scripts/make_release.sh @@ -63,7 +63,7 @@ echo -e "${ACTION}Modifying CMakeLists.txt${NOCOLOR}" sed -i "s/CpuFeatures VERSION ${LATEST_VERSION}/CpuFeatures VERSION ${VERSION}/g" CMakeLists.txt echo -e "${ACTION}Modifying MODULE.bazel${NOCOLOR}" -sed -i "s/CPU_FEATURES_VERSION = \"${LATEST_VERSION}\"/CPU_FEATURES_VERSION = \"${VERSION}\"/g" MODULE.bazel +sed -i "s/version = \"${LATEST_VERSION}\", # CPU_FEATURES_VERSION/version = \"${VERSION}\", # CPU_FEATURES_VERSION/g" MODULE.bazel echo -e "${ACTION}Modifying build.zig.zon${NOCOLOR}" sed -i "s/.version = \"${LATEST_VERSION}\"/.version = \"${VERSION}\"/g" build.zig.zon From 0d68e090ef84a58b3a916a0824c87177bb17f257 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Thu, 25 Jun 2026 09:04:48 -0700 Subject: [PATCH 2/3] use buildozer --- MODULE.bazel | 2 +- scripts/make_release.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MODULE.bazel b/MODULE.bazel index 5b632ef2..ffbb1501 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -1,6 +1,6 @@ module( name = "cpu_features", - version = "0.11.0", # CPU_FEATURES_VERSION + version = "0.11.0", ) bazel_dep(name = "bazel_skylib", version = "1.9.0") diff --git a/scripts/make_release.sh b/scripts/make_release.sh index 59a42242..374e3e08 100755 --- a/scripts/make_release.sh +++ b/scripts/make_release.sh @@ -63,7 +63,7 @@ echo -e "${ACTION}Modifying CMakeLists.txt${NOCOLOR}" sed -i "s/CpuFeatures VERSION ${LATEST_VERSION}/CpuFeatures VERSION ${VERSION}/g" CMakeLists.txt echo -e "${ACTION}Modifying MODULE.bazel${NOCOLOR}" -sed -i "s/version = \"${LATEST_VERSION}\", # CPU_FEATURES_VERSION/version = \"${VERSION}\", # CPU_FEATURES_VERSION/g" MODULE.bazel +buildozer "set version ${LATEST_VERSION}" //MODULE.bazel:cpu_features echo -e "${ACTION}Modifying build.zig.zon${NOCOLOR}" sed -i "s/.version = \"${LATEST_VERSION}\"/.version = \"${VERSION}\"/g" build.zig.zon From 51c8d742906689e9356561e317dc4099b8467aa8 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Thu, 25 Jun 2026 09:13:46 -0700 Subject: [PATCH 3/3] wrong var --- scripts/make_release.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/make_release.sh b/scripts/make_release.sh index 374e3e08..e21166d0 100755 --- a/scripts/make_release.sh +++ b/scripts/make_release.sh @@ -63,7 +63,7 @@ echo -e "${ACTION}Modifying CMakeLists.txt${NOCOLOR}" sed -i "s/CpuFeatures VERSION ${LATEST_VERSION}/CpuFeatures VERSION ${VERSION}/g" CMakeLists.txt echo -e "${ACTION}Modifying MODULE.bazel${NOCOLOR}" -buildozer "set version ${LATEST_VERSION}" //MODULE.bazel:cpu_features +buildozer "set version ${VERSION}" //MODULE.bazel:cpu_features echo -e "${ACTION}Modifying build.zig.zon${NOCOLOR}" sed -i "s/.version = \"${LATEST_VERSION}\"/.version = \"${VERSION}\"/g" build.zig.zon