You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4bb2941
Browse filesBrowse the repository at this point in the historyBrowse files
A conversation is deleted as soon as its item finishes, so the AI Interaction
Intelligence endpoints -- GET .../conversations/{id}/steps and .../items -- have
nothing to read once a run ends. --keep-conversations keeps every conversation,
passed or failed, so a diagnostic batch can be inspected afterwards. Off by
default; also settable via GOODDATA_EVAL_KEEP_CONVERSATIONS.
Enforced inside ChatClient.delete_conversation rather than at each call site.
The thirteen agentic evaluators build their own clients deep in the call tree
and clean up by hand in their finally blocks -- twenty call sites that never
pass through ask() -- so a constructor kwarg would have reached the single-turn
path only. set_keep_conversations follows set_default_turn_timeout, which exists
for the same reason, but applies at deletion rather than construction so a
client that already exists honours it too.
That also closes a gap in --preserve-failed, which has only ever applied to the
single-turn path: every agentic kind deletes unconditionally today, so a failed
agentic conversation could not be inspected even with the flag set.
run_agentic_conversation was written before --preserve-failed landed and was
never wired into it.
Two structural guards: no agentic module may issue its own DELETE, and the
modules must still clean up by default. The first is discovered by scanning the
package, so a fourteenth kind is covered the day it lands.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
0 commit comments