From e4b37135e79e41866bbf4873fce763f803b90eeb Mon Sep 17 00:00:00 2001 From: Petr Benes Date: Thu, 12 Feb 2026 11:25:11 +0100 Subject: [PATCH] fix: silently log reloadAfterReady risk: low --- CHANGELOG.md | 6 ++++++ VERSION | 2 +- screenshotter/operations/reloadAfterReady.go | 4 ++-- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1550ab6..874efb1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [0.20.2] - 2026-02-12 + +### Fixed +- Avoid log.Panicf for ReloadAfterReady operation + ## [0.20.1] - 2026-02-09 ### Fixed @@ -141,6 +146,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added - Initial release +[0.20.2]: https://github.com/gooddata/gooddata-neobackstop/compare/v0.20.1...v0.20.2 [0.20.1]: https://github.com/gooddata/gooddata-neobackstop/compare/v0.20.0...v0.20.1 [0.20.0]: https://github.com/gooddata/gooddata-neobackstop/compare/v0.19.1...v0.20.0 [0.19.1]: https://github.com/gooddata/gooddata-neobackstop/compare/v0.19.0...v0.19.1 diff --git a/VERSION b/VERSION index 9d26321..a158e5b 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.20.1 \ No newline at end of file +0.20.2 \ No newline at end of file diff --git a/screenshotter/operations/reloadAfterReady.go b/screenshotter/operations/reloadAfterReady.go index cf84ad3..ebfae40 100644 --- a/screenshotter/operations/reloadAfterReady.go +++ b/screenshotter/operations/reloadAfterReady.go @@ -2,7 +2,6 @@ package operations import ( "fmt" - "log" "time" "github.com/gooddata/gooddata-neobackstop/internals" @@ -20,7 +19,8 @@ func ReloadAfterReady(logPrefix string, page playwright.Page, scenario internals if _, err := page.Reload(playwright.PageReloadOptions{ WaitUntil: playwright.WaitUntilStateNetworkidle, }); err != nil { - log.Panicf("could not reload: %v", err) + e := "ReloadAfterReady: reload failed: " + err.Error() + return &e } fmt.Println(logPrefix, "reloadAfterReady: page reloaded in", time.Since(t0).Milliseconds(), "ms")