You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Browse filesBrowse the repository at this point in the historyBrowse files
TheovanKraay
committed
address review: make the bash composer error reachable under set -e
PR #4389 Copilot review round 8:
- bash twin: the script runs under set -euo pipefail, so a nonzero composer status in the _PRESET_BLOCKS assignment aborted immediately and the following exit-code check + diagnostic were unreachable. Put the assignment in an 'if !' condition so set -e does not fire, the intended error is printed, and the update still aborts before any context rewrite. Verified with bash -n.
echo"agent-context: preset instruction composer failed (exit $_emit_rc); aborting so the managed section is not rewritten with preset blocks dropped.">&2
354
+
# reach stderr. The assignment is the condition of an `if` so `set -e` does not
355
+
#abort on a nonzero composer status before this diagnostic runs; on failure we
356
+
# abort here so a composer failure never rewrites the section with previously
0 commit comments