Skip to content

Commit b0cf729

Browse files
committed
Fix PR branch selector overflow
1 parent accc2e0 commit b0cf729

1 file changed

Lines changed: 26 additions & 2 deletions

File tree

ui/src/apps/pr-write/App.tsx

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,22 @@ interface BranchItem {
5252
protected: boolean;
5353
}
5454

55+
const branchMenuButtonSx = {
56+
width: "100%",
57+
minWidth: 0,
58+
"& [data-component='buttonContent']": {
59+
minWidth: 0,
60+
overflow: "hidden",
61+
flex: "1 1 auto",
62+
},
63+
"& [data-component='text']": {
64+
minWidth: 0,
65+
overflow: "hidden",
66+
textOverflow: "ellipsis",
67+
whiteSpace: "nowrap",
68+
},
69+
} as const;
70+
5571
type ReviewerItem = { kind: "user" | "team"; id: string; text: string; avatar?: string; org?: string };
5672

5773
function reviewerFromValue(value: string): ReviewerItem {
@@ -570,7 +586,11 @@ function CreatePRApp() {
570586
<Box sx={{ flex: "1 1 120px", minWidth: 0 }}>
571587
<Text sx={{ fontSize: 0, color: "fg.muted", mb: 1, display: "block" }}>base</Text>
572588
<ActionMenu>
573-
<ActionMenu.Button size="small" leadingVisual={GitBranchIcon} sx={{ width: "100%", "& > span": { overflow: "hidden", textOverflow: "ellipsis", whiteSpace: "nowrap" } }}>
589+
<ActionMenu.Button
590+
size="small"
591+
leadingVisual={GitBranchIcon}
592+
sx={branchMenuButtonSx}
593+
>
574594
{baseBranch || "Select base"}
575595
</ActionMenu.Button>
576596
<ActionMenu.Overlay width="medium">
@@ -611,7 +631,11 @@ function CreatePRApp() {
611631
<Box sx={{ flex: "1 1 120px", minWidth: 0 }}>
612632
<Text sx={{ fontSize: 0, color: "fg.muted", mb: 1, display: "block" }}>compare</Text>
613633
<ActionMenu>
614-
<ActionMenu.Button size="small" leadingVisual={GitBranchIcon} sx={{ width: "100%", "& > span": { overflow: "hidden", textOverflow: "ellipsis", whiteSpace: "nowrap" } }}>
634+
<ActionMenu.Button
635+
size="small"
636+
leadingVisual={GitBranchIcon}
637+
sx={branchMenuButtonSx}
638+
>
615639
{headBranch || "Select head"}
616640
</ActionMenu.Button>
617641
<ActionMenu.Overlay width="medium">

0 commit comments

Comments
 (0)