Skip to content

Commit da144bd

Browse files
heiskrCopilot
andauthored
Fix duplicate React keys in breadcrumbs (#64463)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cf5e163d-62e9-40c9-a65a-7eae1ee0392e
1 parent d4ded5f commit da144bd

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎src/frame/components/page-header/Breadcrumbs.tsx‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,10 @@ export const Breadcrumbs = ({ inHeader, variant }: Props) => {
8181
.filter(Boolean)
8282
.map((breadcrumb, i, arr) => {
8383
const title = `${breadcrumb.title}`
84+
// Titles can repeat, like REST's Repositories > Repositories, so they can't be keys.
8485
if (!breadcrumb.href) {
8586
return (
86-
<li key={title}>
87+
<li key={`${i}-${title}`}>
8788
<span data-testid="breadcrumb-title">{breadcrumb.title}</span>
8889
</li>
8990
)
@@ -93,7 +94,7 @@ export const Breadcrumbs = ({ inHeader, variant }: Props) => {
9394
return (
9495
<BrandBreadcrumbs.Item
9596
data-testid={isCurrent ? 'breadcrumb-current' : 'breadcrumb-link'}
96-
key={title}
97+
key={breadcrumb.href}
9798
href={breadcrumb.href}
9899
title={title}
99100
selected={isCurrent}

0 commit comments

Comments
 (0)